Giter VIP home page Giter VIP logo

Comments (11)

legalsylvain avatar legalsylvain commented on July 30, 2024

Hi Pedro, I don't know this module. In fact it depend of 'website' and doesn't depend of 'web'.
But I don't know if it's a good idea to move a repository in a version used in production. Because if people are using this repository, they will loose the module when pulling last version.
So maybe we can plan to mark this module "to be moved" and plan the move for the 9.0 serie.

What is your point of view ?

regards

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

Well, this module has been merged only a while ago (3 weeks), and v8 use is not still widespread, so I don't think it's going to make a lot of harm, but let others say.

from web.

foutoucour avatar foutoucour commented on July 30, 2024

I agree with @legalsylvain and this refactory should be suggested in master rather in v8.0
It is actually pretty hard to mesure the impact of a such move in the current state

👎

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

It's not a refactory, only a reubication. As I said, this module lives in OCA only for a couple of weeks, and it's for v8. The impact is minimal, but if we keep here, for v9 the movement it's going to be more difficult.

from web.

legalsylvain avatar legalsylvain commented on July 30, 2024

Hi again. For V9, we can imagine that we'll do the movement before release, and so without impact.
IE:
we move web/8.0/web_online -> website/9.0/__ unported __.

from web.

legalsylvain avatar legalsylvain commented on July 30, 2024

BTW I don't see the OCA/website project (https://github.com/OCA/website) on http://odoo-community.org/page/website.List, do you know where is it ?

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

OCA web is still not updated for this project. We should warn someone of OCA board of that. @jgrandguillaume, can you check it, please?

from web.

lmignon avatar lmignon commented on July 30, 2024

@pedrobaeza I understand your concern on a technical point of view. Nevertheless, in a functional point of view, the module allows you to write documentation available from the lists and forms in Odoo. IOW, it allows you to document your 'forms' and 'lists' based on the module 'web'. The entry point for this documentation is a button placed on these lists and forms. The module doesn't extend the module website, it uses it but it extends the module web by adding buttons on lists and forms. IMO, oca/web is the good place in a functional POV.

Regards,

lmi

from web.

Cedric-Pigeon avatar Cedric-Pigeon commented on July 30, 2024

I agree with @lmignon. We didn't add any features to website module or even changed its behavior. We simply use it as a tool. The real added-value of help_online module is on the backend and not on the website side.

from web.

sbidoul avatar sbidoul commented on July 30, 2024

That said, hidden inside help_online is the export feature, which is completely generic and could be factored out as a new website_export module.

But that is left as an exercise for future contributors 😄

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

OK, we leave this module here as is.

Thanks for your explanations.

from web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.