Comments (13)
@dra27 do you remember what version we said we would use for graphics? IIRC, it's 5.0.0 since graphics is not tied to the compiler internals
from graphics.
In #11 I put 4.09.0, but it could be either. We could call it 4.09 and then bump it to 5 if there are (ever any) changes?
I’m fairly sure I have an opam-repository branch already done for it - I’ll check in a bit and push it
from graphics.
(It’s obviously not a straight copy of the 4.08.1 one!)
from graphics.
This may not be the place to discuss that, but labltk relies on the ocaml configuration to detect X11. How can we factor the logic, both in and out of opam?
from graphics.
For opam, it’s done via the conf-libX11 package. I haven’t looked in detail at what Jérémie’s done with the Dune port here
from graphics.
I'm tempted to call it 5.0.0 and switch to semantic versioning at the same time, just to avoid confusion.
For X11, I made graphics depend on conf-libX11
. No special compilation flags are used and the following link flags are used:
os_type = Win32
->-lkernel32 -lgdi32 -luser32
- otherwise ->
-lX11
BTW, what authors should we put in the opam file? I put only @xavierleroy for now.
from graphics.
See https://github.com/dra27/opam-repository/blob/graphics-4.09/packages/graphics/graphics.4.09.0/opam
from graphics.
I'm inclined to agree with calling it 5.0.0 - although it feels strange to bump the major version with no changes, it will also feel strange to be using semver and having 4.09.1, 4.10.0 before OCaml does!
from graphics.
(I can redo that opam-repository PR once there's a tag and a confirmed version number)
from graphics.
Let's go for 5.0.0. @dra27 do you have a PR already prepared for this? I was planning to use dune-release
to proceed with the release
from graphics.
I created the release on github. @dra27 let me know if I should proceed with the opam-repository PR
from graphics.
I just diff'd the graphics.opam with the one I'd done by hand: the only difference (apart from things which were better in master
, like the build recipe) is that I added Jun Furuse, J-M Geffroy, Jacob Navia and Pierre Weis to the authors list (I think that was based on everyone whose name appears in a copyright header). I'm just old-school with the opam files - I'd add those files and use dune-release
:)
from graphics.
Alright, I added the other authors and made the release: ocaml/opam-repository#14828
from graphics.
Related Issues (20)
- Graphics: foreground and background colors should be changeable
- 4.10 dune runtest fails undefined reference to caml_process_pending_signals HOT 1
- Unable to install on Mac OS 10.14.6 HOT 33
- Unable to install graphics on a fresh opam installation on Mac OS 10.14.6 HOT 6
- Does this library work for the Windows Linux Subsystem? HOT 4
- Cannot build graphics 5.0.1 on Linux HOT 3
- License exception may need an update HOT 2
- Compilation on native Windows fails HOT 5
- opam install graphics fail on windows. HOT 2
- Cannot load graphics library on ARM macOS HOT 2
- bug in fill_rect
- Cannot install graphics in ubuntu 20.04 on Windows laptop HOT 2
- Question: how to handle close of window? HOT 2
- Mac: Fatal error: exception Graphics.Graphic_failure("Cannot open display ") HOT 2
- Multiple mouse buttons for Graphics
- Graphics crash under Windows HOT 4
- set_text_size doesn't work HOT 2
- Rectangle madness HOT 3
- Graphics background color under Windows HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphics.