Giter VIP home page Giter VIP logo

Comments (15)

rjbou avatar rjbou commented on June 21, 2024 1

The SWHID story is explained in this comment ocaml/opam#5720 (comment).

To complete: As Software Heritage recompute archives from sources, it is not possible to use the original checksum that is given. That's why we rely on swhid given/generated by maintainers & checked by opam repo CI to be sure that we have the good source & opam checks it. There is no blind reliability on SWH servers.

from opam-repository.

zoggy avatar zoggy commented on June 21, 2024 1

But it may be heavier to handle for each new release. I can live with tarballs in the repo, so don't bother, I will add tarballs to lru-cache and css repositories tomorrow and submit a patch for opam files in opam repo.

from opam-repository.

zoggy avatar zoggy commented on June 21, 2024

Don't know what happened, release 0.1.0 is the same as 11 months ago: https://framagit.org/zoggy/ocaml-css/-/tags but indeed this has not the same sha512.

The .gitattributes file was modified in january, to ignore the file .header instead of header when exporting, so the only explanation I see is that gitlab uses current version of .gitattributes to create tar archives instead of the version corresponding to the release tag, producing a different archive file. So it seems ok to change the checksums in opam package file.

from opam-repository.

mseri avatar mseri commented on June 21, 2024

@zoggy I have a copy of the tarball with the correct hash: if you can upload it as release artifact and update the url in the opam file, I'd be happy to send it to you. Otherwise I can upload it on the opam-source-archives

from opam-repository.

zoggy avatar zoggy commented on June 21, 2024

(sorry for the late answer, holidays...) I think it's better to put the tarball on the opam source archives. By the way, may be having all referenced tarballs of opam packages on this source archive repo would be better ? Is there a way to automatize this ?

from opam-repository.

mseri avatar mseri commented on June 21, 2024

That is just a temporary solutions and very limited by the maximum size of repositories. From my understanding the plan is integrating opam with software heritage and then get the sources directly from there. It may be that this is happening soon let me ping @kit-ty-kate that knows more

from opam-repository.

hannesm avatar hannesm commented on June 21, 2024

FWIW, the tarball is available as https://opam.robur.coop/cache/md5/bc/bc4bdcf47b37c7bd50bf9f31c391dcd2

from opam-repository.

zapashcanon avatar zapashcanon commented on June 21, 2024

Since a few years, with the work of @rjbou and myself, all packages are automatically archived by software heritage. Moreover, if the SWHID is added to the opam file, opam is also able to fetch the sources from SWH in case they are missing.

The only (IIRC) thing left to do is patching the opam repository with all the SWHIDs.

from opam-repository.

kit-ty-kate avatar kit-ty-kate commented on June 21, 2024

The only (IIRC) thing left to do is patching the opam repository with all the SWHIDs.

I disagree. Software Heritage is a flawed platform and should not be trusted in my opinion as long as ocaml/opam#5720 is still a problem.

from opam-repository.

zapashcanon avatar zapashcanon commented on June 21, 2024

I tought this had been clarified. The SWHID is a form of checksum and it is checked by opam when downloading and it is thus as safe to use as a checksum: if the SWHID is the same, the content is the same. We could also make opam-repo check that the added SWHID is initially valid (as it does for checksum I guess).

from opam-repository.

hannesm avatar hannesm commented on June 21, 2024

I have to admit, I appreciate the work on software heritage. I'd still have a better feeling if opam would always check recorded checksums. What is the price? not too much. What is the value? Well, who ensures that software heritage servers are never compromised?

So, the value of locally verifying checksums is that opam can be trusted without any thoughts on software heritage, it's operations etc.

from opam-repository.

zapashcanon avatar zapashcanon commented on June 21, 2024

I'd still have a better feeling if opam would always check recorded checksums.

As I'm trying to explain, it does, but here the checksum would simply be called "SWHID". You can compute it locally, check that it matches the recorded SWHID etc.

from opam-repository.

hannesm avatar hannesm commented on June 21, 2024

Ah, thanks Raja. I keep on forgetting about the details about swhid.

from opam-repository.

zoggy avatar zoggy commented on June 21, 2024

Thanks @hannesm for the tarball.

So hosting tarballs on opam source archive is not the perennial way to go, and SWH is not yet ready. Gitlab does not seem to offer a way to upload tarballs either, except in the repo itself (for example in the public directory, used for the web pages) but I'd like to avoid that. Any other place to upload such arhives ?

from opam-repository.

mseri avatar mseri commented on June 21, 2024

from opam-repository.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.