Comments (8)
monnier
commented on August 13, 2024
1
As for the things to leverage from newer versions - I was mostly thinking of
things like newer core APIs (seq, map, etc). We can create a separate ticket
for this to discuss specifics.
This sounds a hammer looking for a nail.
It should be the need for a specific functionality/simplification that
should drive the motivation to bump up the required Emacs version, not
the other way around.
from tuareg.
monnier
commented on August 13, 2024
Currently tuareg-mode targets the ancient Emacs 24.4 that was released way
back in 2014 and pretty much no one uses these days. Even the most
conservative Emacs distros like Debian and RHEL have Emacs 27 these days, so
I'd propose bumping the required Emacs to 26.1. (I like the idea of
supporting the last 3 major Emacs releases in general)
I'll let Christophe make such a decision, but I think the discussion
would be more meaningful if we talked about the corresponding impact on
our code. e.g. what could we simplify, which new features could we use,
...
Stefan
from tuareg.
bbatsov
commented on August 13, 2024
@monnier That's already done, btw. (in Tuareg 3.0)
As for the things to leverage from newer versions - I was mostly thinking of things like newer core APIs (seq, map, etc). We can create a separate ticket for this to discuss specifics.
from tuareg.
mattiase
commented on August 13, 2024
newer core APIs (seq, map, etc)
I doubt seq and map bring us more than slower code but there may be other things to make use of.
There is some low-hanging fruit for someone who wants to clean up compatibility code for Emacs 25 or earlier.
from tuareg.
bbatsov
commented on August 13, 2024
No argument from me. I just didn't have time to compile the list of concrete proposals that's why I mentioned the typical type of cleanup/facelift work I do when I adopt newer Emacs versions.
I doubt seq and map bring us more than slower code but there may be other things to make use of.
They bring more consistent API and eliminate the need for using libraries like cl-lib. For me that's a win, but obviously opinions on the subject vary.
There is some low-hanging fruit for someone who wants to clean up compatibility code for Emacs 25 or earlier.
Yeah, certainly. That's one area I plan to look into when I have a bit of time.
from tuareg.
mattiase
commented on August 13, 2024
They bring more consistent API and eliminate the need for using libraries like cl-lib.
cl-lib is an Emacs built-in package just like seq and map. The main difference is that cl-lib is generally richer and faster, especially the macros. No user will thank us for using either, and I rarely touch them when performance is even slightly important.
Maybe SMIE has features in more recent Emacs versions that could benefit us (Stefan would know). The number one complaint about Tuareg must be the maddening indentation, especially of comments, in some cases; doing something about that would be most welcome.
The Xref API has seen some improvement since Emacs 24 but perhaps it's more naturally to have it interface with Merlin.
from tuareg.
bbatsov
commented on August 13, 2024
The Xref API has seen some improvement since Emacs 24 but perhaps it's more naturally to have it interface with Merlin.
Merlin has been using xref for a while now (see https://github.com/ocaml/merlin/blob/master/emacs/merlin-xref.el). Note that xref didn't even exist before Emacs 25.1.
from tuareg.
mattiase
commented on August 13, 2024
Merlin has been using xref for a while now
Looks like there's an Xref-related PR gathering dust there – Merlin seems short-handed with respect to Emacs these days.
from tuareg.
Related Issues (20)
- "Mismatched parentheses" when closing comment HOT 1
- Un-git `tuareg-site-file.el` HOT 4
- Unbind `C-c ?` and `C-c C-h` (maybe) HOT 22
- Can't run Ocaml REPL HOT 3
- Find alternate file doesn't seem to care about tuareg-other-file-alist HOT 1
- Possible bug : missing file tuareg-compat HOT 3
- 3.0 version not tagged HOT 8
- Package cl is deprecated HOT 2
- Tuareg depends on emacs-nox HOT 3
- Triggers warning for using obsolete aliases on Emacs HOT 5
- outline mode
- Document the differences between tuareg and caml-mode HOT 5
- Completion in the *OCaml* buffer HOT 3
- tuareg.3.0.0 fails to load in emacs on macOS when installed using opam HOT 1
- How does one jump to definition? HOT 3
- Add configuration option(s?) to make highlighting behave closer to what it was like in 2.2 . HOT 2
- Use tree-sitter HOT 1
- tuareg-current-fun-name returns inaccurate results, breaking which-function-mode
- create a custom variable for process-connection-type HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tuareg.