Comments (3)
True, but the idea was to make it work with bootstrap when I made it (and bootstrap uses .modal).
It could be a config param to make it add the modal class when using bootstrap (or not).
from ocmodal.
It currently causes an issue if you have any other bootstrap modals on the page. I have existing modals that are display none but the css for ocModal changes their display to block so they're no longer hidden. Ideally, the ocModal's modal html would use something like class="modal oc-modal" with the custom css targeted at the oc-modal class instead of the default bootstrap class. Bootstrap's .modal class default is display: hidden.
from ocmodal.
Ideally, the ocModal's modal html would use something like class="modal oc-modal" with the custom css targeted at the oc-modal class instead of the default bootstrap class.
Definitely agree with @cmiller86 on this. Unless this library depends on Bootstrap, it seems there should be a separation of concerns.
(Freaking love this library btw!)
from ocmodal.
Related Issues (18)
- Close modal by backdrop clic/tap HOT 1
- Modal closes on enter
- Modal position off the top of the screen
- Custom backdrop class HOT 2
- Is this project still being maintained? HOT 2
- scope clear
- How do I pass data back from modal's controller on close? HOT 3
- Missing license HOT 1
- Dismiss modal when clicking on backdrop HOT 1
- Typos in the doc
- Pass arguments to close function doesn't work
- Open Close animation HOT 7
- controller $scope HOT 2
- How to link with router? HOT 1
- Backdrop height with multiple modals
- ocModal closes on "enter" key when an input box is focused on. HOT 1
- controllerAs syntax HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocmodal.