Comments (10)
Ah, right, I see now. The release however mentions the change, so it was intentional: https://github.com/octet-stream/form-data-encoder/releases/tag/v1.8.0 the "Backport headers changes"
from form-data-encoder.
Sorry I broke your product. The https://github.com/octet-stream/form-data-encoder/releases/tag/v1.9.0 should revert these changes. 1.8.0 will be marked as deprecated. Thanks for reaching me out!
from form-data-encoder.
Thank you so much.
We plan on moving to v2. For now our build toolchain doesn't emit an ESM artifact but we will change this in the next few weeks - to be able to benefit from the most recent versions of your fantastic package, and some others that are also moving to ESM-only.
Again, thanks. Much appreciated.
from form-data-encoder.
I'm gonna close this, hope your issue is resolved.
from form-data-encoder.
This is rather a bug fix for #9, otherwise this method will return NaN
if File without known length was discovered, so I had to make this change. In v2 it was also introduced in minor release. This is unusual change in minor, but it was necessary.
from form-data-encoder.
The commit message is "fix eslint issue". There is no mention about a bug fix. Instead it looks like a cosmetic change. Except if the commit message is misleading.
from form-data-encoder.
And anyway, this change prevents every project that depends on the library to build with the strict setting of typescript compiler. This is huge.
from form-data-encoder.
Okay, I can revert this.
from form-data-encoder.
Thanks. We have fixed the version to 1.7.2. in our own projects, for now - we have a critical product that requires to be built tonight. But it may not be as easy for some other teams. 🙂
from form-data-encoder.
Also please consider upgrade to v2
when it is possible, the 1.x
will no longer receive updates (except for those things I might broke in 1.8.0)
from form-data-encoder.
Related Issues (15)
- README outdated HOT 3
- Appending files is not working after `[email protected]` HOT 12
- Type error using Node.js global `FormData` instance with `FormDataEncoder` constructor HOT 3
- Support for `multipart/mixed` and other multipart content types HOT 4
- `FormDataLike` iterator type is incorrect HOT 4
- `formdata-node` `FormData` is not assignable to `new FormDataEncoder(formData)` HOT 13
- error TS2304: Cannot find name 'ReadableStream' HOT 6
- Part's headers should contain `Content-Length` header if size is known HOT 7
- This is invalid encoder. It will not work for NodeJS HOT 2
- Breaking change in minor release HOT 2
- Lookbehind Regexp for normalizeValue method doesn't work on Safari HOT 5
- Minimum required Node.js version HOT 4
- Lint error in LowercaseObjectKeys.d.t HOT 8
- `Content-Length` header is `NaN` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from form-data-encoder.