Giter VIP home page Giter VIP logo

Comments (4)

pengwynn avatar pengwynn commented on May 9, 2024

Ah, let's shoot for consistency. Please send over a patch if you don't mind.

from octokit.rb.

gvaughn avatar gvaughn commented on May 9, 2024

Will do.

I've got a better explanation now. This would work for the public github, but fail with github:enterprise because for gh:ent, the api_endpoint is of the form 'http://our.domain/api/v3' and faraday treats a path with a leading slash as absolute, so it drops the '/api/v3'. I've found more than this one file that has the leading slash. Looking to put in a general assert against leading slash at perhaps the Request#request level.

from octokit.rb.

gvaughn avatar gvaughn commented on May 9, 2024

#122

from octokit.rb.

catsby avatar catsby commented on May 9, 2024

Merged #122

from octokit.rb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.