Comments (8)
@time-trader I think one part of the problem is a typo in the
output_manifest
key - there shouldn't be a:
at the end. This is what's in your twine file currently:"output_manifest:": [ { "key": "open_foam_result", "purpose": "A dataset containing solution fields of an openfoam case." }, { "key": "airfoil_cp_values", "purpose": "A file containing cp values" } ]
@cortadocodes Yes. That was a problem. I will go cry in the corner for not noticing that ":"
from octue-sdk-python.
@time-trader I think I've fixed this but please send me your Twine file and a minimal amount of code that reproduces the issue so I can make sure.
from octue-sdk-python.
@thclark I'm not sure the second and third tickboxes are related to this issue now?
from octue-sdk-python.
@thclark I'm not sure the second and third tickboxes are related to this issue now?
Can you make a test where twine file specifies an output manifest, then assert that the value of output_manifest
is not none in run()
?
On the documentation, this seems like a weird place to start so happy with skipping that. Although I have a strong feeling we should actually deprecate input_dir
on the analysis object to dissuade people from using it. It's best to use the path
property on the Dataset
(which is a Pathable
) in question (that way we can ultimately allow datasets to reside in different locations)
from octue-sdk-python.
Here is the twine that resulted in this bug: https://gitlab.com/windenergie-hsr/aerosense/digital-twin/fsi-twins/foam_2d_twine/-/blob/dev/twine.json
from octue-sdk-python.
@time-trader I think one part of the problem is a typo in the output_manifest
key - there shouldn't be a :
at the end. This is what's in your twine file currently:
"output_manifest:": [
{
"key": "open_foam_result",
"purpose": "A dataset containing solution fields of an openfoam case."
},
{
"key": "airfoil_cp_values",
"purpose": "A file containing cp values"
}
]
from octue-sdk-python.
@thclark the other problem appears to be in the Runner._update_manifest_path
method:
@staticmethod
def _update_manifest_path((manifest, pathname):
if manifest is not None and hasattr(pathname, "endswith"):
if pathname.endswith(".json"):
manifest.path = os.path.split(pathname)[0]
# Otherwise do nothing and rely on manifest having its path variable set already
return manifest
This returns None
if the pathname
is None
, erasing the manifest
if it exists.
I might be lacking some context here, but it seems incorrect that a Manifest
can have a path at the same time as the output_manifest_path
argument of the Runner.run
method is None
.
from octue-sdk-python.
@time-trader please don't cry. If you promise not to cry we'll promise to move octue/twined#16 up the priority board to prevent exactly this scenario from happening.
from octue-sdk-python.
Related Issues (20)
- Add ability to run callback function on answers when using `Child.ask_multiple`
- Allow specifying project name by environment variable
- Drop python3.7 support
- Add documentation about `bigquery` installation extra HOT 1
- Make octue services easy to test and patch HOT 1
- Make `Dataset` instantiation recursive by default
- Negative number of missing events logged HOT 1
- Add `octue logs` CLI command HOT 1
- Order events by datetime instead of `order` HOT 3
- Add option to strip metadata when replaying events
- Speed up event replayer
- Make local/temporary file/directory deletion thread-safe
- Make sure `octue` CLI commands are in line with `answer_question` method of running a service
- Document `EventReplayer`
- Turn off event validation in `EventReplayer` by default
- Add alternative constructor to `EventReplayer` that gets events from event store
- Access to output datasets via output manifest expires after 7 days HOT 1
- Disable use of signed URLs in output manifests by default
- No way to determine if a service revision exists at ask time
- Docs refer to wrong schema regsitry URL
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octue-sdk-python.