Giter VIP home page Giter VIP logo

Comments (9)

LKozakewycz avatar LKozakewycz commented on July 17, 2024 21

@AustinGomez I've submitted a pull request with the necessary changes: #155

From this, you can do something like the following:

    constructor(props) {
        super(props);
        this.uploader = null;
        this.handleUpload = this.handleUpload.bind(this);
    }
    
    handleUpload() {
        this.uploader.uploadFile();
    }

    render() {
        return (
            <div>
                <ReactS3Uploader
                    autoUpload={false}
                    ref={uploader => { this.uploader = uploader; }}
                    ...
                    />
            
                <input type="button" value="Upload" onClick={this.handleUpload} />
            </div>
        )
    }

from react-s3-uploader.

LKozakewycz avatar LKozakewycz commented on July 17, 2024 1

I'm currently playing with this and haven't yet had time to try it out but I have modified the following which I'm hoping for results.

    propTypes: {
        signingUrl: PropTypes.string,
        getSignedUrl: PropTypes.func,
        preprocess: PropTypes.func,
        onProgress: PropTypes.func,
        onFinish: PropTypes.func,
        onError: PropTypes.func,
        signingUrlMethod: PropTypes.string,
        signingUrlHeaders: PropTypes.oneOfType([
          PropTypes.object,
          PropTypes.func
        ]),
        signingUrlQueryParams: PropTypes.oneOfType([
          PropTypes.object,
          PropTypes.func
        ]),
        signingUrlWithCredentials: PropTypes.bool,
        uploadRequestHeaders: PropTypes.object,
        contentDisposition: PropTypes.string,
        server: PropTypes.string,
        scrubFilename: PropTypes.func,
        s3path: PropTypes.string,
        inputRef: PropTypes.func,
        autoUpload: PropTypes.bool
    },

    getDefaultProps: function() {
        return {
            preprocess: function(file, next) {
                console.log('Pre-process: ' + file.name);
                next(file);
            },
            onProgress: function(percent, message) {
                console.log('Upload progress: ' + percent + '% ' + message);
            },
            onFinish: function(signResult) {
                console.log("Upload finished: " + signResult.publicUrl)
            },
            onError: function(message) {
                console.log("Upload error: " + message);
            },
            server: '',
            signingUrlMethod: 'GET',
            scrubFilename: function(filename) {
                return filename.replace(/[^\w\d_\-\.]+/ig, '');
            },
            s3path: '',
            autoUpload: true
        };
    },

and for getInputProps function...

getInputProps: function() {
        // declare ref beforehand and filter out
        // `inputRef` by `ReactS3Uploader.propTypes`
        var additional = {
            type: 'file',
            ref: this.props.inputRef
        };

        if ( autoUpload ) {
            additional.onChange = this.uploadFile;
        }

Then presumably, using the below properties, you can prevent it from auto uploading and then use the ref to call the uploadFile function.

<ReactS3Uploader
     autoUpload={false}
     ref={uploader => { this.uploader = uploader; }}
     ...
     />

This is what I'm trying... however I'm off to grab some sleep so I shall test this tomorrow.

from react-s3-uploader.

AustinGomez avatar AustinGomez commented on July 17, 2024 1

@LKozakewycz Thanks for this. Gladly awaiting your work ๐Ÿ˜„

from react-s3-uploader.

sniepoort avatar sniepoort commented on July 17, 2024

+1 for this

from react-s3-uploader.

arvinsim avatar arvinsim commented on July 17, 2024

I was surprised that this feature wasn't implemented since this is a very common use case. +1

from react-s3-uploader.

seanadkinson avatar seanadkinson commented on July 17, 2024

Didn't see that this issue had so many votes! Yeah, it is totally a use-case we should support. Scanning the code, it shouldn't be too hard to conditionally omit the listener on this line, then just call uploadFile via a reference to the component. Anyone want to take a stab at a PR?

from react-s3-uploader.

AustinGomez avatar AustinGomez commented on July 17, 2024

Very surprised you can't do this yet. +1

from react-s3-uploader.

seanadkinson avatar seanadkinson commented on July 17, 2024

I appreciate your input @AustinGomez and others. I don't currently use this library, and don't have a lot of spare time at the moment - I just merge PRs and try to make sure things aren't broken. If anyone would like to provide this functionality, I'll be happy to review and merge. I usually get new features merged and released within a few hours. Thanks!

from react-s3-uploader.

seanadkinson avatar seanadkinson commented on July 17, 2024

Released v.4.6.0 with autoUpload={false} support.

from react-s3-uploader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.