Comments (5)
Shouldn't the Flow
s be created with nominal_value=Investment()
to allow for investments in any case?
from oemof-solph.
That might work (have to try it tomorrow) but it isn't shown like that in any of the examples. And then the _set_flows
function wouldn't make much sense to me? Or is there another reason why the Investment
objects in the flow should be overwritten? Maybe because of the lifetime_inflow
`lifetime_outflow` attributes?
from oemof-solph.
Maybe, it makes sense to rewrite this thing anyway. I'd consider replacing the fixed relations between the investments by a limit to the c-rate. It would be an internal property that exists independent from the nominal values of the flows.
from oemof-solph.
Yeah, you are right about locating this to the _set_flows
method, @lensum , I think.
- The case of
invest_relation_input_output
is not accounted for here. In my view, a check needs to be added in_set_flows
. - Also, for the other cases, the type of
flow.investment
is evaluated. I think, this needs to beflow.nominal_value
instead according to the latest structural changes.
from oemof-solph.
I see multiple problems with the current implementation. First of all, we create unexpected investment variables. (If the Flows do not have to have one, they are silently created.) Secondly, you can do confusing things. The invest_relation_input_capacity=0.1
will be typically read as "it needs 10 hours to charge the storage". However, you can set a "max" to the flows to bypass that:
electric_storage = cmp.GenericStorage(
label="electric_storage",
inputs={el_bus: solph.Flow(max=10)}, # will be charged in 1 hour
outputs={el_bus: solph.Flow()},
nominal_storage_capacity=solph.Investment(
ep_costs=elstor_epc, existing=1200, maximum=2100
),
invest_relation_input_capacity=0.1,
invest_relation_input_output=0.1,
)
from oemof-solph.
Related Issues (20)
- Multi-period development HOT 1
- Docs on retreiving constraint values seem to be not correct
- Oemof Installation Test accepts not working cbc
- Decomissioning of exisiting capacity (non-invest) in MultiPeriod HOT 2
- Oemof-network requirement
- Unclear error HOT 1
- Pandas gives a future warning for usage of "H" in a date_range
- Implausible diverging results comparing 1-year-multi-period & multi-period optimization HOT 6
- v0.4.x TypeError on Transformer init with basic example HOT 2
- GenericCHP component example is broken HOT 2
- Allow multiple outputs at OffsetConverter HOT 4
- Results processing should check if optimisation succeeded
- Using `custom_attributes` of `Source` and `Sink` classes fails HOT 1
- Add periodic values to invest relation of generic storage
- Implement alternative back-end to Pyomo (e.g. linopy) HOT 9
- How to define a switching Converter ? HOT 7
- The `OffsetConverter` is broken in the new implementation HOT 4
- The basic_example.py is broken HOT 1
- Aggregate all sorts of tools configurations in `pyproject.toml` HOT 1
- The online documentation could have a more appealing/modern look
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oemof-solph.