Wrong area calculation for mass balance plot and glacier wide mass balance about glacier_simulator HOT 4 CLOSED

Haha, quite fun ;-).

I agree that using trapeze is not good because internally, the model does not do that.

Now you are suggesting a fractional bin area, which is OK, but... to be honest I would do it even much simpler. Maybe I'm seeing this wrong, but in OGGM the AAR is calculated as:

h, w, mbh = mbmod.get_annual_mb_on_flowlines()
pacc = np.where(mbh >= 0)
aar = np.sum(w[pacc]) / np.sum(w)

Does this help or not?

from glacier_simulator.

For the AAR I used:

total_area = model.fls[0].area_m2
accumulation_area = np.sum(np.where(model.fls[0].surface_h > mb_model.ela_h,
                                    model.fls[0].bin_area_m2,
                                    0))
AAR = accumulation_area / total_area

which is more or less the same as you posted I think. So for the AAR calculation I do not use a fractional bin area.

But I use fractional bin area for the mb plot, because if not it looks like this (I just remembered that was why I introduced it):

So by using the fractional bin area I hide the discrete model behind a smoothed curve ;)

from glacier_simulator.

I understand! Thanks

from glacier_simulator.

Equations for trapezoidal subarea calculations, just for documentation:

from glacier_simulator.