Giter VIP home page Giter VIP logo

Comments (5)

ogxd avatar ogxd commented on June 15, 2024 1

Thank you @tgross35 for your feedback and ideas! Having it work on stable is definitely a must, I'll try to address this as soon as I can πŸ˜„

from gxhash.

tgross35 avatar tgross35 commented on June 15, 2024 1

Glad to be of help! Another option is to add a Cargo feature called nightly and gate anything that needs it under #[cfg(feature = "nightly)], with a fallback implementation under #[cfg(not(feature = "nightly))]. Then anyone who needs the highest performance can enable the feature, everyone else can live with the slightly slower stable version.

Doing something similar to gate all handwritten simd could help make this work in WASM and other targets (no_std)

Thank you for the invitation, I accepted but don't know how I can help - I know about rust mechanics but not so much about the inner workings of hash algorithms. I suppose feel free to ping me if you need a hand figuring something out.

from gxhash.

tgross35 avatar tgross35 commented on June 15, 2024

Awesome project by the way!

from gxhash.

ogxd avatar ogxd commented on June 15, 2024

Done :)
'avx2' feature will require unstable toolchain however. I don't know if there is a way to have to work on the stable toolchain, but I think that can be addressed later.
I've added you as a contributor in case you want to review.

from gxhash.

ogxd avatar ogxd commented on June 15, 2024

It seems to also address another usability issue: I am under the impression that stdsimd required users to build with target-cpu=native otherwise performance would be degraded. Anyway it is much better without all these unstable features now, merging this and releasing.
Thanks a lot!

from gxhash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.