Giter VIP home page Giter VIP logo

Comments (3)

ojarva avatar ojarva commented on June 10, 2024

Hi @bbtfr ,

When I saw this, I was wondering two things,

a) Why did I add f-strings and
b) Why didn't tests catch this.

Now that I got into checking, tests aren't executed with python3.5 because of https://www.python.org/downloads/release/python-3510/ - 3.5 is pretty much EOL'd.

Considering probably the only blocker for using 3.5 is f-strings which are easily replaced with .format, I'm happy to accept that as a PR but I personally consider 3.5 to be something that is no longer officially supported.

from python-sshpubkeys.

bbtfr avatar bbtfr commented on June 10, 2024

Agree with you, I got this error only because I have a Python 3.5 integration test in my lib.
So, do you think having a python_requires='>=3.6', in setup.py is a better solution?

from python-sshpubkeys.

ojarva avatar ojarva commented on June 10, 2024

That would work as well.

from python-sshpubkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.