Comments (3)
I can help with that. Would you be up to add Github Action to prevent merging inconsistent code? Usually it better to have several places to enforce linting, as contributors can bypass it on their local machine. In my experience, Xcode project script + CI check works great.
from minisim.
@Garfeild Project script + CI running on every PR would be ideal setup 👍🏻
from minisim.
I have tried to integrate SwiftLint as plugin. There are some pros and cons with such integration.
Pros:
- It shows warning/errors during compilation time in Xcode directly.
- It's easy to share with any contributor and harder to disable.
Cons
- It lints whole project and couldn't lint only changed files. This is not visible for current state of the project (takes ~0.25s).
- Until we fix all warnings, build log will be polluted with them. Easy to miss important warnings.
- After I cleaned up everything, it was 4 warnings.
Personally, I think it gives us good start and we can ignore first problem and mitigate second. And I would still introduce CI check.
from minisim.
Related Issues (20)
- Issues with Pixel 7 Emulator
- Create Release Github Action
- New feature: add option to open logcat HOT 10
- New feature: Add UI for changing default terminal
- Docs: create a documentation on Custom Commands
- New feature: allow users to change MiniSim icon HOT 1
- New feature: pin emulator to the top of the list HOT 15
- Feature Request: Use it without Android SDK HOT 2
- Issue: error after clicking Minisim menu item HOT 2
- New feature: Search input above emulator list to filter them
- New feature: handle case when there is no space in the MenuBar
- New feature: delete android emulator HOT 2
- Enable `force_unwrapping` SwiftLint rule
- Enable `implicitly_unwrapped_optional` SwiftLint rule
- Enable `no_magic_numbers` SwiftLint rule HOT 2
- Create GitHub Actions pipeline for SwiftLint
- New feature: add check for updates button to the Main menu
- New feature: Indicate that there is available update
- Feat: Connect device via WiFi HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minisim.