Property SetupEventArgs.IsModifying has other behavior than method Extensions.IsModifying() about wixsharp HOT 2 CLOSED

Thank you. Indeed it is a defect. Has been fixed in the codebase and will be available with the very next release.

As for DRY, I am not convinced it is exactly the case. :)
Session extension methods and SetupEventArs are completely different creatures and they work with very different runtime objects. One with a short living property bag Session (belongs to WiX) to and another one with a custom persistent dictionary (belongs to Wix#) . While they do share part of the API, their implementing classes Extensions and SetupEventArgs have very different responsibilities.

Implementing an external abstraction layer would satisfy DRY (and possible this is what eventually is going to happen) but considering the amount of overlap and the current complexity of the implementation I think it would be rather an over-optimization and also a violation of YAGNI. :)

But thank you again. I missed it.

from wixsharp.

Thanks.

As for DRY, I hear you and understand your reasoning. Would probably have done the same. But perhaps one could argue that the fact that this bug was missed is proof that DRY would have been a good choice ;)

from wixsharp.