Can you please clarify from which commit of VUnit this can be used ? <p dir="auto"

Pinging <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Cool. Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hover

Or is <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

I decided to pull in <a class="issue-link js-issue-link" data-error-text="Failed to lo

VUnit support: vhdl_standard should be of type 'str' about edalize HOT 10 CLOSED

olofk commented on July 23, 2024

VUnit support: vhdl_standard should be of type 'str'

from edalize.

Comments (10)

cmarqu commented on July 23, 2024

Pinging @julian-becker who added the VUnit support.

from edalize.

julian-becker commented on July 23, 2024

When I did the original implementation, I was developing against vunit 4.2.0. Since then, it seems there have been some subtle changes to this API. The changes in #88 should fix this, but unfortunately break compatibility for vunit 4.2.0...

from edalize.

olofk commented on July 23, 2024

@kraigher @LarsAsplund Do you have any comments on this? Did the API change in a backwards-incompatible way or is there a way to support both older and newer VUnit?

from edalize.

kraigher commented on July 23, 2024

The Public API has always been str. Internally we switched to an object to get a better implementation of some rules based on the standard. In 4.2.0 there was a bug where the Public API accepted the VHDLStandard object which it should not have. In 4.3.0 we fixed this http://vunit.github.io/release_notes.html

So in summay VHDLStandard is a private class that should thus never appear on the public api

from edalize.

olofk commented on July 23, 2024

Cool. Thanks @kraigher for clearing that up. @krishnan-gopal, @julian-becker is there anything we can do in the Edalize backend to use the public API instead? I haven't had time to look at the implementation myself unfortunately

from edalize.

olofk commented on July 23, 2024

Or is #88 the correct fix that will work on all versions except for 4.2.0?

from edalize.

kraigher commented on July 23, 2024

Well 4.2.0 could be considered broken so maybe you do not need to support it. Also I would recommend always using the public api since that is the only thing we care about being stable.

from edalize.

julian-becker commented on July 23, 2024

Thanks @kraigher, for the additional support on this issue!
My observation is that on both vunit_hdl 4.2.0 and 4.1.0, I get the following error when using the vhdl_standard argument as string:

Compiling into lib:       ..\src\vunit_examples-vhdl_run_0\test_control.vhd                                                   Traceback (most 
recent call last):
File "c:\progs\python37\lib\site-packages\vunit\ui.py", line 838, in main
    all_ok = self._main(post_run)
File "c:\progs\python37\lib\site-packages\vunit\ui.py", line 880, in _main
    return self._main_compile_only()
File "c:\progs\python37\lib\site-packages\vunit\ui.py", line 1012, in _main_compile_only
    self._compile(simulator_if)
File "c:\progs\python37\lib\site-packages\vunit\ui.py", line 1044, in _compile
    printer=self._printer)
File "c:\progs\python37\lib\site-packages\vunit\simulator_interface.py", line 172, in compile_project
    self.compile_source_files(project, printer, continue_on_error)
File "c:\progs\python37\lib\site-packages\vunit\simulator_interface.py", line 244, in compile_source_files
    if self.__compile_source_file(source_file, printer):
File "c:\progs\python37\lib\site-packages\vunit\simulator_interface.py", line 189, in __compile_source_file
    command = self.compile_source_file_command(source_file)
File "c:\progs\python37\lib\site-packages\vunit\modelsim_interface.py", line 138, in compile_source_file_command
    return self.compile_vhdl_file_command(source_file)
File "c:\progs\python37\lib\site-packages\vunit\modelsim_interface.py", line 162, in compile_vhdl_file_command
    + [self._std_str(source_file.get_vhdl_standard()), '-work', source_file.library.name, source_file.name])
File "c:\progs\python37\lib\site-packages\vunit\modelsim_interface.py", line 151, in _std_str
    if vhdl_standard <= VHDL.STD_2008:
File "c:\progs\python37\lib\functools.py", line 105, in _ge_from_lt
    op_result = self.__lt__(other)
File "c:\progs\python37\lib\site-packages\vunit\vhdl_standard.py", line 39, in __lt__
    return int(self._standard) < int(other._standard)  # pylint: disable=protected-access
AttributeError: 'str' object has no attribute '_standard'
ERROR: Failed to build vunit:examples-vhdl:run:0 : 'c:\progs\python37\python.exe' exited with an error code

With 4.3.0, 4.0.0 and 3.9.0, the string version works just fine, and I think we should probably stick with it as it is the proper API usage and since - as you said - 4.2 could be considered broken in this respect.

from edalize.

olofk commented on July 23, 2024

I decided to pull in #88 by @julian-becker which hopefully should fix this issue. @krishnan-gopal can you confirm this works for you and close the issue if it does?

from edalize.

krishnan-gopal commented on July 23, 2024

Ok, i just tested this now and it works. Thanks a lot.

from edalize.

VUnit support: vhdl_standard should be of type 'str' about edalize HOT 10 CLOSED

Comments (10)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent