Sending notification to over 1000+ devices about pyfcm HOT 5 CLOSED

Yes, is there any problem with that?
https://firebase.google.com/docs/cloud-messaging/http-server-ref#notification-payload-support
This parameter specifies a list of devices (registration tokens, or IDs) receiving a multicast message. It must contain at least 1 and at most 1000 registration tokens.

To send to more than 1000 reg ids, we have to do it in chunks

from pyfcm.

I am fully aware that we need split it into chunks, but.. the problem is that you won't be able to send remaining 1450 notifications. That will "break" after parsing first response. You should probably append parsed response to list and return that list after for loop.

or should we.. ?

Split it into chunks by yourself and call notify_multiple_devices method 3 times - but that is not the point. Am I right ?

from pyfcm.

There was a little misunderstanding but I eventually get what you were saying.
It has been fixed in the latest update here https://github.com/olucurious/PyFCM/blob/master/pyfcm/fcm.py#L275, https://github.com/olucurious/PyFCM/blob/master/pyfcm/baseapi.py#L175 and https://github.com/olucurious/PyFCM/blob/master/pyfcm/baseapi.py#L177

Thanks for pointing out the issue.

from pyfcm.

Thanks for quick reaction :) but .. there is one more thing. You made similar mistake once again: https://github.com/olucurious/PyFCM/blob/master/pyfcm/baseapi.py#L198
You are returning dict inside for loop, instead of list (that contains parsed dicts) after for loop.

from pyfcm.

Fixed here https://github.com/olucurious/PyFCM/blob/develop/pyfcm/baseapi.py#L200

I can't appreciate you enough, and it will be helpful if you can help contribute some unit tests.

from pyfcm.