Comments (14)
Psalmzee
commented on August 17, 2024
3
On Thu, Aug 11, 2022 at 11:44 AM Olúwásetèmi ***@***.***> wrote:
I want us to close out all the PR but we have to merge from the first pr
created and not recent ones. What are your thoughts @oseunabiola
<https://github.com/oseunabiola> @Psalmzee <https://github.com/Psalmzee>
@Succynice <https://github.com/Succynice>
—
Reply to this email directly, view it on GitHub
<#329>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQDL6ALWJIZJXRNKG4LOGMTVYTKSJANCNFSM56HWA5DQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
from altschool-opensource-names.
Succynice
commented on August 17, 2024
3
Yes I'm in agreement
from altschool-opensource-names.
tobisupreme
commented on August 17, 2024
I am also in agreement!
At the time of writing this, the latest unmerged pull request is #415.
@Psalmzee suggested this earlier and I think it is a way we can proceed.
What we can do is put a 'peg" after #415, then start to interact with the earliest commits asking the contributors to sync their forked repo with the main branch, and then resolve conflicts.
If it's too much to handle, they forgo their local copy and make a fresh clone of the newly synced fork. They can then make changes to that and wait for it to be merged.
We can also update the instructions on the readme and suggest changes should not be made to the first or the last line.
from altschool-opensource-names.
Oluwasetemi
commented on August 17, 2024
I agree with this. How do we activate this and communicate this to the community?
from altschool-opensource-names.
tobisupreme
commented on August 17, 2024
We can outline the steps to take in a file on the repository, and then point contributors to it. In addition to putting the link in the pull requests as we close them, we can also maybe make an announcement on Slack, or during the next live class.
In that regard, I've opened a new pull request ( #474 ) and requested your review.
from altschool-opensource-names.
JumaCodes
commented on August 17, 2024
All this is good, but I believe you guys need to communicate it quickly on the slack channels so that merging will not cause conflict as I believe that not everyone created a branch before the pull request.
from altschool-opensource-names.
tobisupreme
commented on August 17, 2024
Yes, you're right. It's as a result of the numerous merge conflicts that we are taking this approach.
Please also help us spread word when you can 😁
from altschool-opensource-names.
JumaCodes
commented on August 17, 2024
I will surely do so.
from altschool-opensource-names.
JumaCodes
commented on August 17, 2024
But before it closes let me put my name there chief
.
from altschool-opensource-names.
Succynice
commented on August 17, 2024
Wow! This is wonderful.
I think I'm free to start closing PRs that still have conflict, starting from the earliest ones which has stayed up to 6hrs after receiving a review as planed
from altschool-opensource-names.
Oluwasetemi
commented on August 17, 2024
Yes.
from altschool-opensource-names.
Oluwasetemi
commented on August 17, 2024
I can conformably close this issue right?
from altschool-opensource-names.
JumaCodes
commented on August 17, 2024
Sure
from altschool-opensource-names.
tobisupreme
commented on August 17, 2024
I can conformably close this issue right?
Yessur 🥳
from altschool-opensource-names.
Related Issues (16)
- AltSchool Logo in light mode HOT 8
- Creating a new branch before making changes should be added to the README. HOT 3
- clicking altschool link in the readme does not open a new tab HOT 9
- New Feature: Display the list of names in a page
- sorting the names HOT 8
- No search functionality HOT 4
- Refereeing HOT 15
- Permission to add my name HOT 1
- adding abdullahi chindo's name HOT 2
- Duplicate names
- The duplicate name test is not case-sensitive HOT 2
- Make pages so we wont have a long list of names
- Redesigning the Alt_Shcool logo HOT 3
- A theme toggle functionality HOT 2
- Duplicate names HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from altschool-opensource-names.