on login redirect to the last page about awaas-vishwa-fe HOT 17 OPEN

assign this to me, i will fix this.

from awaas-vishwa-fe.

Sure, I'm assigning this issue to you @rishikush31 . Do let me know if you need any help.

from awaas-vishwa-fe.

bhai backend is not running due to env materials ,
how do i test what i did

from awaas-vishwa-fe.

I think backend wouldn't be required, you just need to set the environment variable in frontend for api call to the backend at https://awaas-vishwa-be.onrender.com

from awaas-vishwa-fe.

https://awaas-vishwa-be.onrender.com/api/v1/auth/login like this?

from awaas-vishwa-fe.

Yes

from awaas-vishwa-fe.

Thanks for your help brother, now ill be working on it.

from awaas-vishwa-fe.

i have made it go back to whatever was last opened , example
case : Home->item1->login
after login: item1 will open

case: Home->item1->signup->login
after login : signup page will be shown

is that all right..

if you'd want to make auth page (login/signup) closed , then ill have to change the react routes and code a little.. would this be fine?

from awaas-vishwa-fe.

hey check for pull requests, i've made the correction.

from awaas-vishwa-fe.

Sure, I'll look into it

from awaas-vishwa-fe.

You can solve this issue by updating the code with

if (redirect) { window.history.back(); }

in LoginPage.jsx in line number 44

from awaas-vishwa-fe.

um that way it will be not good i think, because if you are currently at item page, you go to register from there and then after registering (or clicking to go to login page) and then if you login , you will be redirected to register page only because the previous page you were on was register,
also if user shuffles in between login and signup page more than once , he will have to go through that loop to go back to item page.

from awaas-vishwa-fe.

also can you explain what the error means which is being shown in pull request

from awaas-vishwa-fe.

sorry for not communicating timely , its hard on github, we can talk on ig or wherever you like about this

from awaas-vishwa-fe.

um that way it will be not good i think, because if you are currently at item page, you go to register from there and then after registering (or clicking to go to login page) and then if you login , you will be redirected to register page only because the previous page you were on was register, also if user shuffles in between login and signup page more than once , he will have to go through that loop to go back to item page.

It would work fine

from awaas-vishwa-fe.

sorry for not communicating timely , its hard on github, we can talk on ig or wherever you like about this

We connect over Instagram at instagram.com/om_raj_sharma

from awaas-vishwa-fe.

This Issue Resolved By @rishikush31 or not? if not then you can aasign me , i'll fix this issue in a better way.

from awaas-vishwa-fe.