Comments (8)
@SaptakS @micahflee unfortunately I still reproduce it on latest main branch.
I find that it is easier to reproduce if you actually start a share (in Tor mode e.g non-local-only) and visit the share in Tor Browser. You don't need to download the share. Just once you've loaded the page, stop the share in OnionShare and then command-quit the app entirely. This seems to invoke the infinite 'Waiting for circuits to close'.
I think the reason this influences the test is that OnionShare's tor client knows there are 'active' circuits that have been built. Whereas often otherwise, it closes straight away as there is nothing to do.
We must have some sort of loop that is creating an infinite number of OnionCleanupThreads or something.. maybe to do with the main event loop? (no idea)
from onionshare.
I reproduce it on macOS. If I comment out alert.exec()
then the problem goes away for me.
Do you know why we are explicitly calling the .exec
method on the Alert() class? We don't do that with other Alert
widgets elsewhere (Update Checker, Autostop timer alerts, etc). Maybe we don't need it?
Also, I couldn't figure out how to make this Alert functionality only fire if not in local-only
mode. Not super important (maybe harmless) but wondered if it was skippable entirely for local mode (maybe not).
from onionshare.
Actually, commenting it out doesn't fix it, I quit OnionShare while downloading a share and I didn't see the dialog box appear and got a crash (Destroyed while thread is still running).
I've tried using show()
as well but it doesn't help.
The "Dialog is not top level modal window" I am not sure is a side-effect or a root cause. Googling it gives me nothing.
The fact that it is reproducible on macOS but not Linux suggests something up with QTWidgets that is OS specific, or something to do with the event loop.
from onionshare.
I am actually not able to reproduce this issue in Mac OS any longer. Can you test once more? I wonder if it got fixed as part of #1790
from onionshare.
@mig5 I will try reproducing this again and debugging.
from onionshare.
I know @SaptakS had trouble reproducing this but I feel like it's a really impacting bug, I nearly always reproduce it on a 2017 Macbook Pro.
I wonder if we should just remove the thread that tries to 'wait' for tor circuit activity to close? We introduced that because closing OnionShare too soon after it 'stops' (and thereby severing the tor circuits) caused downloads to be incomplete on the client side. The original PR: #1236 and associated issue #929
Maybe we should check if that is still required..
from onionshare.
I definitely agree that this is an impacting bug and we should find some solution to this. I am able to get the popup, but just one and not infinite. I wonder if it's somehow fixed in Mac silicon but not in Intel Macs.
from onionshare.
Definitely still get this on 2.6.1 on my Intel Mac.
from onionshare.
Related Issues (20)
- Add option for automatically sharing a website HOT 1
- Allow translating the web interfaces? HOT 4
- new tag? HOT 2
- fix flatpak syncing HOT 1
- Creating Persistent Receive Files from CLI Only HOT 3
- Flask
- test
- Allow Upload and Download using Share Mode HOT 1
- python-stem is obsolete HOT 2
- Doesn't load fonts from html file HOT 2
- Unable to generate QR Codes
- Improve flatpak go and python module generators
- Qt6 depdenency & backport to Debian stable / Tails HOT 1
- Improvements to the receive mode web frontend
- v2.6.1: onionshare depends on onionshare_cli but also conflicts with onionshare_cli
- Fix deprecated Enums in new PySide6 versions
- Move description to long_description in setup.py
- Make Japanese as available language on documentation HOT 1
- Flatpak version: "No module named 'PySide2" HOT 8
- Crash after Onion share quit, while it was sharing 3 files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onionshare.