Write tests about onionshare HOT 5 CLOSED

@ecmendenhall thanks for the pull request and working on tests! This is great, and I'd love if you'd want to work on splinter/selenium tests too.

I tried running the test with python test/onionshare_test.py but there was no output, and I even made one fail and there was still no output. I decided to merge it in anyway since it's not harming anything sitting there.

You mentioned in #30 that you'd need to break a lot of the functionality out of main() into separate functions to test further, but I've actually already done a lot of this in the gui different branch. In order to make it easier to test, I've just merged gui into master. The GUI isn't done yet, but it does indeed work.

from onionshare.

Thanks, I'll check out the updated master tomorrow. Excited for a GUI!

I used nose as the testrunner, which does some magic to find and run tests. If you pip install nose and then run nosetests in the project root it should find and run them. If you don't want to add a development dependency, the built in unittest module would probably be fine.

from onionshare.

I don't mind adding dev dependencies for tests. Do you want to add instructions for running the tests to README.md and include it in your next pull request?

from onionshare.

Good idea. I added a section on running tests in #40.

from onionshare.

Since there are now some tests, this issue should be closed and replaced with smaller issues targeting specific tests.

Also, the tests are currently failing on master. This should never happen. I recommend using CI, as well as Git push hooks, to prevent this from happening in the future.

from onionshare.