QuickOpen: Add scrollbar to menu about oni2 HOT 6 CLOSED

It's been kind of an organic process! I'm opening to moving the <FlatList /> over to Revery though 👍

from oni2.

FYI: I'm working on this as part of the menu renovation project.

from oni2.

for context to anyone looking into this the menu is a <Flatlist/> component which means it only renders the items in view. Revery does have a ScrollView which does come with a scrollbar but that would not work in this case as if list the menu renders is not virtualised (i.e. renders all visible and nonvisible components) this list becomes v. v. slow.

A solution here would be adding the option to render a scrollbar in the menu ?adding it to the virtualised list as a toggleable option?

from oni2.

Weird... supposedly FlatList should have showsVerticalScrollIndicator prop as true by default? Do we just have to render the scrollbar (well, that and handle dragging the scrollbar) in the render function then 🤔

from oni2.

We actually have our own FlatList: https://github.com/onivim/oni2/blob/master/src/editor/UI/FlatList.re

So we'd need to add a similar property to that as well as a bar for it.

from oni2.

:/ why do we have our own anyway

from oni2.