when watching, add ability to ignore hidden files (including tests!) about ginkgo HOT 5 OPEN

hey @ewollesen this is great, thank you!

but I'm sure I haven't thought about this as much as the authors

I can assure you that, at this point, you absolutely have!

the issue and use-case all make sense to me. I think adding --ignore-hidden-files makes sense though I'm wondering if this should be the default behavior going forward. What if instead we add --include-hidden-files as a configuration option in case folks want to monitor hidden files but, other than that, ginkgo watch by default should ignore hidden files.

Thoughts? A PR would be great!

from ginkgo.

Thoughts? A PR would be great!

Sounds good. I think it does make more sense logically to ignore files starting with '.' by default. The only potential downside I see is that anyone that's used to the behavior could be caught unaware by the change. That said, I rather doubt anyone is creating hidden files with tests in them. Hopefully it won't break anyone's processes.

I'll re-work my version with the flag and push a PR ASAP.

from ginkgo.

Heh, out of curiousity, I just checked, and 'go test' ignores hidden files by default. I don't see a flag for enabling the behavior.

They include this in the output of go help test:

Files whose names begin with "_" (including "_test.go") or "." are ignored.

from ginkgo.

Good call to check. I think we can just follow its behavior - if anyone opens an issue we can add the flag later. Sound reasonable?

from ginkgo.

That sounds fine to me. It makes the PR simpler too. :)

PR #1405 is ready for you when you have a few minutes.

from ginkgo.