[BUG] Search with global = true still shows "Search in docs" etc. about compose HOT 9 CLOSED

450840b introduces new problems:

1. It seems that there is no longer a way to see which section is being searched if global is false.
2. Translations now show e.g. Suche in <no value>.

from compose.

@ltguillaume,

This is a breaking change indeed.

This changed

[search_field_placeholder]
  other = "Search {{ .section }}"

to

[search_field_placeholder]
  other = "Search"

from compose.

It should work now, with or without the change.

from compose.

But it seems that you removed the indicator that the user is only searching a specific section if global = false, right?

If I understand that correctly, I think that could lead to confusion.

from compose.

@ltguillaume, that indicator still exists when global is false. I modified how it's injected.

Previously it was baked into the translation string, that's not necessary.

from compose.

Ok, so I need to remove it from the translations, thanks. It just said Suche in <no value> but perhaps the section is shown after that and it was cut off due to the size of the input box. I'll check soon.

from compose.

so I need to remove it from the translations

Not necessarily. I added a fallback in the template that sets the <no value> part to an empty string. Just for backward compatibility.

from compose.

I'm not following. Does this mean there is a translation missing, or that the new JS function passes on an empty string, which it shouldn't in any case.

from compose.

@ltguillaume,

Have you tested the new change on your local though? Because I tested and all was good. Feels like we're now arguing over theory

About the empty string, I was referencing this line

(dict "section" "") }}

👆🏼 part ensures that the right context is parsed if you have other = "search in" or other = "search in {{ .section }}".

from compose.