Throw an exception on bad workflow format about onyx HOT 6 CLOSED

What kind of checking do you have in mind? Workflow should be a vector, containing vectors with two keyword elements?

Do you want to check for things like cycles?

from onyx.

I think, first, we can only validate the DAG form of the workflow - since the map form is now unpacked to a vector-of-vectors anyhow. Let's start with this:

• Workflow is a vector
• Workflow contains elements only of vectors
• Of those inner vectors, they are all size 2
• Of those inner vectors, the two elements are both keywords
• Both of those keywords refer to entries in the catalog
• "input" nodes in the DAG refer to entries in the catalog with :onyx/type :input
• There are no cycles

I'd be super happy with any subset of these.

from onyx.

See PR.

Checks not addressed:
Cycle checking.
Does not check whether tasks with no incoming nodes are type input (better checked when actually generating the DAG to check for cycles).

Checks additionally addressed:

• Input nodes should not have incoming edges.
• Output nodes should not have outgoing edges.

I assume that's correct?

from onyx.

That looks great to me. I'll merge these changes.

Want to make separate issues for cycling checks and no incoming nodes?

from onyx.

Merged and deployed under 0.4.1-SNAPSHOT. Other changes pending.

from onyx.

Remaining issues can be tracked here #44

from onyx.