HTTP does not set ajax dataType, resulting in failure of negotiation about opal-jquery HOT 7 CLOSED

You think you can prepare a PR for this (and #44)? 😸

from opal-jquery.

@lloeki I was looking into this and realized that seems to be more an issue between jQuery and Rails than something specific to opal-jquery. Is that correct?

If that's true maybe you're good to go with the official global ajax setup:
http://api.jquery.com/jQuery.ajaxSetup/

from opal-jquery.

@elia yeah you're right at a technical level. That's why I was reluctant to make any patch.

For a user point of view there is a high chance opal-jquery will be used with Rails. I suppose a little note in the doc/examples regarding dataType may shed quite a useful light. Alternatively, wrapping the ajaxSetup facility or even better, providing a similar yet idiomatic system in pure opal could be great. Thoughts?

from opal-jquery.

I like the latter option, something like this should look good:

HTTP.configure(
  url: "/xmlhttp/",
  global: false,
  type: "POST"
)

# or

HTTP.setup(
  url: "/xmlhttp/",
  global: false,
  type: "POST"
)

maybe we can keep both with an alias… what do you think?

from opal-jquery.

or even

HTTP.setup = {
  url: "/xmlhttp/",
  global: false,
  type: "POST"
}

and the getter

HTTP.setup # => { url: "/xmlhttp/", global: false, type: "POST" }

from opal-jquery.

@lloeki for the Rails side I wonder if it's something that should be backed into jquery_ujs.js itself

from opal-jquery.

I like the setup accessors, it bridges well with jQuery and doesn't look awkward in ruby.

HTTP.configure begs for the idiomatic configuration DSL by way of a block. It may be useful to set up properties that pertain to the wrapper itself (along with those that act directly on jQuery, but in a more DSL way)

from opal-jquery.