I may be wrong but it probably should serialize it to query string properly, but now i

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I've just monkey-patch it in my apps. Add this in your code. <div class="snippet-c

HTTP.get doesn't serialize get data (#{payload}) to query string. about opal-jquery HOT 5 CLOSED

opal commented on June 9, 2024

HTTP.get doesn't serialize get data (#{payload}) to query string.

from opal-jquery.

Comments (5)

elia commented on June 9, 2024

@classyPimp seems this right fix, can you send a PR for it?

(Attaching tests would be great too, of course 😃)

from opal-jquery.

classyPimp commented on June 9, 2024

I would gladly do, but I can't provide a test because: I can't access the request headers query strings. (response url would return it without query string).
`
%x{
if (typeof(#{payload}) === 'string') {
#{settings}.data = payload;
}

#This would properly serialize:

  if (#{@method == "get" && payload.is_a?(Hash)}) {
    settings.data = #{payload.to_n}
  }

  else if (payload != nil) {
    settings.data = payload.$to_json();
    settings.contentType = 'application/json';
  }

}
`

from opal-jquery.

daltonrenaldo commented on June 9, 2024

any update on this? I'm having the same issue

from opal-jquery.

classyPimp commented on June 9, 2024

I've just monkey-patch it in my apps. Add this in your code.

class HTTP
  def send(method, url, options, block)
    @method   = method
    @url      = url
    @payload  = options.delete :payload
    @handler  = block

    @settings.update options

    settings, payload = @settings.to_n, @payload

    %x{
      if (#{@method == "get" && @payload != nil}) { #<====this is added
        payload = #{@payload.to_n};
        #{settings}.data = $.param(payload);
      }
      else if (typeof(#{payload}) === 'string') {
        #{settings}.data = payload;
      }
      else if (payload != nil) {
        settings.data = payload.$to_json();
        settings.contentType = 'application/json';
      }
      settings.url  = #@url;
      settings.type = #{@method.upcase};
      settings.success = function(data, status, xhr) {
        return #{ succeed `data`, `status`, `xhr` };
      };
      settings.error = function(xhr, status, error) {
        return #{ fail `xhr`, `status`, `error` };
      };
      $.ajax(settings);
    }

    @handler ? self : promise
  end
end

from opal-jquery.

elia commented on June 9, 2024

This can be achieved by passing data: {foo: :bar} instead of payload: {foo: :bar}, the contents of data will be prepared via #to_n

from opal-jquery.

Recommend Projects