Giter VIP home page Giter VIP logo

Comments (12)

CommCody avatar CommCody commented on June 12, 2024 1

fwiw @toddbaert I'm looking at this, limited bandwidth, but interested in completing this

from dotnet-sdk.

austindrenski avatar austindrenski commented on June 12, 2024 1

Thanks @CommCody, there was a similar report over the weekend, so looking into this.

from dotnet-sdk.

CommCody avatar CommCody commented on June 12, 2024 1

Fwiw I'm running these commands on windows 11. Directly against the dotnet cli.

from dotnet-sdk.

CommCody avatar CommCody commented on June 12, 2024 1

Hi @toddbaert , totally fair
I've had some illness going around in the family, so I've been distracted.

My current state of work is here https://github.com/CommCody/dotnet-sdk/tree/add-in-memory-provider

From memory:

  • one test fails
  • some new public apis have no, or no decent documentation
  • basic structure from java was followed, but divergence for open generic type usage

KR
Joris

from dotnet-sdk.

toddbaert avatar toddbaert commented on June 12, 2024

Hey @CommCody ! I've assigned you.

It's no problem if this takes some time. I'll keep it assigned to you for now.

from dotnet-sdk.

NeerajGartia21 avatar NeerajGartia21 commented on June 12, 2024

@CommCody are you working on this?
This issue looks interesting and I will be happy to collaborate with you.

from dotnet-sdk.

CommCody avatar CommCody commented on June 12, 2024

Mildly, I do have some work on my fork. My time is limited however, so I'm not very actively working on it.

from dotnet-sdk.

NeerajGartia21 avatar NeerajGartia21 commented on June 12, 2024

Can I continue from where you left?

from dotnet-sdk.

toddbaert avatar toddbaert commented on June 12, 2024

Can I continue from where you left?

@NeerajGartia21 if @CommCody has a partial implementation, maybe you'd be better off working on the Java reconnect tests, or on the Error enhancements in JS you recently commented on.

from dotnet-sdk.

NeerajGartia21 avatar NeerajGartia21 commented on June 12, 2024

Cool, that sounds good.

from dotnet-sdk.

CommCody avatar CommCody commented on June 12, 2024

Hi @toddbaert I was updating my code to further implement this issue, but now I can't build the main branch anymore. the build fails with:

E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to refer
ence them from your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs
E:\openfeature-dotnet-sdk\src\OpenFeature\OpenFeature.csproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to reference them fro
m your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs [E:\openfeature-dotnet-sdk\test\OpenFeature.Tests\OpenFeature.Tests.csproj]

If I disable the following line in Directory.Packages.props my issues are gone:

    <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />

I have the following sdk installed: 8.0.101

from dotnet-sdk.

toddbaert avatar toddbaert commented on June 12, 2024

@CommCody Hey! Unfortunately this has become a bit of a blocker.

If you aren't able to finish this in the next few days, would you mind if I take it over? I'm glad to pick up where you left off if you give me a branch, and will maintain as much of your work as possible, and make you a commit co-author.

from dotnet-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.