Giter VIP home page Giter VIP logo

Comments (4)

beeme1mr avatar beeme1mr commented on August 22, 2024 1

@rcrowe would you be willing to improve the log message? I think that would be a good place to start.

from go-sdk.

skyerus avatar skyerus commented on August 22, 2024

Thanks for bringing this to attention.

I wonder whether we ought to amend the ProviderResolutionDetail.Error() func to append the message to the error code, I agree that in its current state there isn't enough information provided by the default logger to be all that useful.

As for whether the default logger logs or not I'm still leaning towards errors being logged by default as it can be frustrating for something to not be working and seeing no indication of that in the logs. I'd like to hear other opinions on the matter @james-milligan @toddbaert @beeme1mr

from go-sdk.

beeme1mr avatar beeme1mr commented on August 22, 2024

It sounds like there are two issues here. First, the error log is missing key information in order to be useful. It definitely makes sense to improve that error message (and quickly review other log messages). Second, is the the default logging behavior. I would expect there not to be any logging during normal behavior. Originally, I felt it was a good idea to log errors by default but perhaps that's best left up to the user to decide. This seems like something we can change based on user feedback. If the general consensus is to no-op by default, let's do that.

from go-sdk.

beeme1mr avatar beeme1mr commented on August 22, 2024

Thanks @rcrowe, you change will be included in the next release.

from go-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.