Comments (4)
@rcrowe would you be willing to improve the log message? I think that would be a good place to start.
from go-sdk.
Thanks for bringing this to attention.
I wonder whether we ought to amend the ProviderResolutionDetail.Error()
func to append the message to the error code, I agree that in its current state there isn't enough information provided by the default logger to be all that useful.
As for whether the default logger logs or not I'm still leaning towards errors being logged by default as it can be frustrating for something to not be working and seeing no indication of that in the logs. I'd like to hear other opinions on the matter @james-milligan @toddbaert @beeme1mr
from go-sdk.
It sounds like there are two issues here. First, the error log is missing key information in order to be useful. It definitely makes sense to improve that error message (and quickly review other log messages). Second, is the the default logging behavior. I would expect there not to be any logging during normal behavior. Originally, I felt it was a good idea to log errors by default but perhaps that's best left up to the user to decide. This seems like something we can change based on user feedback. If the general consensus is to no-op by default, let's do that.
from go-sdk.
Thanks @rcrowe, you change will be included in the next release.
from go-sdk.
Related Issues (20)
- Update README to be consistent with other SDKs
- Changes to support spec `v0.6.0` compliance HOT 4
- implement named client support: open-feature/spec@4cf8229 HOT 1
- implement initialization/shutdown: open-feature/spec@a4ffec3
- Implement event support HOT 1
- Conform to spec `v0.7.0` HOT 6
- event handlers should run immediately if the associated provider is in the state associated with that handler already
- [FEATURE] Follow official Go guidance on how to organize a module? HOT 9
- [FEATURE] Follow up for 227 HOT 2
- [BUG] Panic when following getting started tutorial HOT 2
- [FEATURE] Blocking provider mutator HOT 1
- [FEATURE] Expose domain specific provider metadata getter HOT 1
- [FEATURE] Upgrade to Go version 1.20
- [FEATURE] Implement transaction context HOT 5
- [FEATURE] Implement domain scoping HOT 2
- [FEATURE] Make provider interface "stateless", SDK maintains provider state
- Should retrieving a value really provide an error? HOT 5
- [FEATURE] Move to log/slog logging HOT 2
- [BUG] Awkward usage when trying to evaluate a boolean flag in a complex conditional HOT 8
- [FEATURE] New test-oriented client HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-sdk.