If you use rotator.AddRotator to build a <code class=

rotator.AddRotator doesn't exit when the process is terminated about cert-controller HOT 1 OPEN

open-policy-agent commented on May 31, 2024

rotator.AddRotator doesn't exit when the process is terminated

from cert-controller.

Comments (1)

maxsmythe commented on May 31, 2024

I don't think the watch uses that context. Here is the code that sets up the controller:

cert-controller/pkg/rotator/rotator.go

Lines 568 to 595 in 54af894

 func addController(mgr manager.Manager, r *ReconcileWH) error { 

 // Create a new controller 

 c, err := controller.New("cert-rotator", mgr, controller.Options{Reconciler: r}) 

 if err != nil { 

 return err 

 } 

 err = c.Watch( 

 source.NewKindWithCache(&corev1.Secret{}, r.cache), 

 &handler.EnqueueRequestForObject{}, 

 ) 

 if err != nil { 

 return fmt.Errorf("watching Secrets: %w", err) 

 } 

 for _, webhook := range r.webhooks { 

 wh := &unstructured.Unstructured{} 

 wh.SetGroupVersionKind(webhook.gvk()) 

 err = c.Watch( 

 source.NewKindWithCache(wh, r.cache), 

 handler.EnqueueRequestsFromMapFunc(reconcileSecretAndWebhookMapFunc(webhook, r)), 

 ) 

 if err != nil { 

 return fmt.Errorf("watching webhook %s: %w", webhook.Name, err) 

 } 

 } 

 return nil

IIRC controller-runtime registers the intent for a watch, but actually starts it via the manager, which passes on the context (though I could be misremembering).

The background context appears to be passed into the various client.Get() calls that occur during a reconcile event.

from cert-controller.

rotator.AddRotator doesn't exit when the process is terminated about cert-controller HOT 1 OPEN

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func addController(mgr manager.Manager, r *ReconcileWH) error {
	// Create a new controller
	c, err := controller.New("cert-rotator", mgr, controller.Options{Reconciler: r})
	if err != nil {
	return err
	}

	err = c.Watch(
	source.NewKindWithCache(&corev1.Secret{}, r.cache),
	&handler.EnqueueRequestForObject{},
	)
	if err != nil {
	return fmt.Errorf("watching Secrets: %w", err)
	}

	for _, webhook := range r.webhooks {
	wh := &unstructured.Unstructured{}
	wh.SetGroupVersionKind(webhook.gvk())
	err = c.Watch(
	source.NewKindWithCache(wh, r.cache),
	handler.EnqueueRequestsFromMapFunc(reconcileSecretAndWebhookMapFunc(webhook, r)),
	)
	if err != nil {
	return fmt.Errorf("watching webhook %s: %w", webhook.Name, err)
	}
	}

	return nil