Bug: When adding brob/plug11ty.com "not valid" error about open-sauced HOT 14 CLOSED

my gut tells me that this would be a sufficient check:

const isRelativeUrl = !(url.substr(0,7) === 'http://' || url.substr(0,8) === 'https://');

The upsides to this would be:

• we don't try to get too clever with regex
• we don't try to anticipate all of the TLDs

Test suite would need adjustment too.
https://github.com/open-sauced/open-sauced/blob/4a26b94eaa1a1094ee0dd0d7ca76ead50da2acc4/src/tests/util.test.js

from open-sauced.

I want to work on this issue, please assign me

from open-sauced.

I made a PR
Please check it out

from open-sauced.

I haven't reproduced yet, but here is the code path I suspect is responsible:

Repo Form checking validity:

Validity Checker catching .com and assuming this is an absolute URL:

From there, I haven't validated, but I believe the intention would be for us to consider this a "relative URL".

from open-sauced.

I haven't reproduced yet, but here is the code path I suspect is responsible:

Repo Form checking validity:

open-sauced/src/components/AddRepoForm.jsx

Line 23 in 4a26b94

const [isValid, repoUrl] = isValidRepoUrl(urlRef.current.value.replace(/\s+/g, ""));

Validity Checker catching .com and assuming this is an absolute URL:

open-sauced/src/lib/util.js

Line 5 in 4a26b94

const isRelativeUrl = !(url.substr(0, 4) === "http" || url.includes(".com") || url.includes("www."));

From there, I haven't validated, but I believe the intention would be for us to consider this a "relative URL".

Needs a fix for sure :D

from open-sauced.

Marking this as a good first issue - I think there's enough context to work with.

from open-sauced.

the RFC itself is terrible, the function could use more regex to properly check for owner/repo and not complicate so much with URL handling - there are node classes now handling that including https://developer.mozilla.org/en-US/docs/Web/API/URL

from open-sauced.

For what it's worth, this repo is flagged as invalid, for similar reasons:
https://github.com/httpie/httpie

from open-sauced.

Please review the CONTIBUTING.md for info on how to assign yourself to the issue.

from open-sauced.

.take

from open-sauced.

Thanks for taking this on! If you have not already, join the conversation in our Discord

from open-sauced.

@mtfoley my test cases are not getting cleared. I am not getting what changes I need to do in https://github.com/open-sauced/open-sauced/blob/4a26b94eaa1a1094ee0dd0d7ca76ead50da2acc4/src/tests/util.test.js
although brob/plug11ty.com is valid to add but test cases are getting failed.
so can you please me through this process?
I am a newbie in this open-source contributions

from open-sauced.

@mtfoley my test cases are not getting cleared. I am not getting what changes I need to do in https://github.com/open-sauced/open-sauced/blob/4a26b94eaa1a1094ee0dd0d7ca76ead50da2acc4/src/tests/util.test.js
although brob/plug11ty.com is valid to add but test cases are getting failed.
so can you please me through this process?
I am a newbie in this open-source contributions

Hey, I don't see you having forked the open-sauced repo, once you do, you can apply the fixes discussed above. There is nothing you need to do to the unit test, it's the code that this issue requires fixing.

If that is not the case IE you are not looking to contribute, let us know and we will assign to someone else :D

from open-sauced.

🎉 This issue has been resolved in version 0.52.1 🎉

The release is available on:

• GitHub release
• ghcr.io container (@latest dist-tag)

Your semantic-release bot 📦🚀

from open-sauced.