Giter VIP home page Giter VIP logo

Comments (8)

anuraaga avatar anuraaga commented on May 25, 2024 1

@thisthat Filed an issue for it :)

from build-tools.

Oberon00 avatar Oberon00 commented on May 25, 2024

Can the tag-mechanism be extended for that? E.g. if we allow multiple tags, we can just designate certain tags (stable, experimental?) for that use case.

from build-tools.

anuraaga avatar anuraaga commented on May 25, 2024

TBH despite me maintaining this repo, I haven't looked into the details on how the Java generator works :P

https://github.com/open-telemetry/opentelemetry-java/blob/main/buildscripts/semantic-convention/templates/SemanticAttributes.java.j2

If the attributes processed by that template can be filtered by tag, then that would work fine I think. I guess it might still need a change, adding has_tag method around here?

from build-tools.

Oberon00 avatar Oberon00 commented on May 25, 2024

The generator would need to be updated anyway, as currently it allows only a single tag. has_tag might be useful too, although Jinja is basically a fully-fledged Python dialect and probably already has a contains method or "in" operator you could call on any exposed list attribute.

Maybe special support for stability declarations is warranted though. We could then e.g. declare a full group as stable and only mark certain attributes as experimental or vice-versa. Tags are not (yet) supported for groups.

from build-tools.

thisthat avatar thisthat commented on May 25, 2024

Given the special use case of this "tag", I would suggest adding it as its own field in the YAML definition.

from build-tools.

thisthat avatar thisthat commented on May 25, 2024

Discussing this with @Oberon00, we come up with changing the deprecated attribute to stability: deprecated|experimental|stable, where stable is the default one.
WDYT @anuraaga?

from build-tools.

anuraaga avatar anuraaga commented on May 25, 2024

Sounds good, thanks!

from build-tools.

Oberon00 avatar Oberon00 commented on May 25, 2024

Hmm, on the other hand, maybe we should keep deprecated separate after all. If we deprecate an attribute that was never stable, it would be different from deprecating a formerly stable attribute. Except if we say we have a strict policy of immediately removing experimental attributes worth deprecating. But given the wide use of our "experimental" semantic conventions, I'm not sure that works.

from build-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.