Giter VIP home page Giter VIP logo

Comments (8)

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024 2

In the past we were not very strict with changes and releases and had quite relaxed attitude towards breaking changes.

I believe we need to be significantly more careful going forward, particularly with this repo.

I agree that we need to make numbered releases from this repo and all other repos that depend on this repo must only refer to the numbered releases in this repo. In addition all other repos may document which version of this repo they implement.

And it will be much nicer to have a centralized matrix showing versions of proto implemented by each repo - SDK or Collector. We just need to find a good way to maintain such matrix.

from opentelemetry-proto.

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024 1

I do not think we want to tie versions of Collector and Proto. They evolve at different paces.

If the plan for OTLP to have independent release versioning, then Collector should only use released versions of opentelemetry-proto to make sure we are able to guarantee compatibility between SDKs and Collector.

This is a good suggestion.

if the collector release process is documented somewhere, it should include releasing opentelemetry-proto as a prerequisite.

Why is this needed? It is not necessarily a prerequisite if the Collector does not want to use any changes introduced in opentelemetry-proto since the last release.

I think your first suggestion is sufficient: Collector and SDKs to only use released versions of opentelemetry-proto.

from opentelemetry-proto.

nilebox avatar nilebox commented on June 17, 2024

@owais if the collector release process is documented somewhere, it should include releasing opentelemetry-proto as a prerequisite.

@bogdandrutu @tigrannajaryan If the plan for OTLP to have independent release versioning, then Collector should only use released versions of opentelemetry-proto to make sure we are able to guarantee compatibility between SDKs and Collector.

See #79 (comment)

from opentelemetry-proto.

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024

v0.4.0 released: https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v0.4.0

from opentelemetry-proto.

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024

I am working on incorporating this in the Collector now: open-telemetry/opentelemetry-collector#1142

from opentelemetry-proto.

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024

Closing this since the release is done.

from opentelemetry-proto.

nilebox avatar nilebox commented on June 17, 2024

@tigrannajaryan FYI v0.4.0 is marked as "pre-release", and as a result the v0.3.0 is still marked as the "latest release" on the page https://github.com/open-telemetry/opentelemetry-proto/releases

from opentelemetry-proto.

tigrannajaryan avatar tigrannajaryan commented on June 17, 2024

I can change to a regular "release". Does anyone know if editing a release has any implications other than how it is labeled?

from opentelemetry-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.