Comments (8)
In the past we were not very strict with changes and releases and had quite relaxed attitude towards breaking changes.
I believe we need to be significantly more careful going forward, particularly with this repo.
I agree that we need to make numbered releases from this repo and all other repos that depend on this repo must only refer to the numbered releases in this repo. In addition all other repos may document which version of this repo they implement.
And it will be much nicer to have a centralized matrix showing versions of proto implemented by each repo - SDK or Collector. We just need to find a good way to maintain such matrix.
from opentelemetry-proto.
I do not think we want to tie versions of Collector and Proto. They evolve at different paces.
If the plan for OTLP to have independent release versioning, then Collector should only use released versions of opentelemetry-proto to make sure we are able to guarantee compatibility between SDKs and Collector.
This is a good suggestion.
if the collector release process is documented somewhere, it should include releasing opentelemetry-proto as a prerequisite.
Why is this needed? It is not necessarily a prerequisite if the Collector does not want to use any changes introduced in opentelemetry-proto since the last release.
I think your first suggestion is sufficient: Collector and SDKs to only use released versions of opentelemetry-proto.
from opentelemetry-proto.
@owais if the collector release process is documented somewhere, it should include releasing opentelemetry-proto
as a prerequisite.
@bogdandrutu @tigrannajaryan If the plan for OTLP to have independent release versioning, then Collector should only use released versions of opentelemetry-proto
to make sure we are able to guarantee compatibility between SDKs and Collector.
See #79 (comment)
from opentelemetry-proto.
v0.4.0 released: https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v0.4.0
from opentelemetry-proto.
I am working on incorporating this in the Collector now: open-telemetry/opentelemetry-collector#1142
from opentelemetry-proto.
Closing this since the release is done.
from opentelemetry-proto.
@tigrannajaryan FYI v0.4.0
is marked as "pre-release", and as a result the v0.3.0
is still marked as the "latest release" on the page https://github.com/open-telemetry/opentelemetry-proto/releases
from opentelemetry-proto.
I can change to a regular "release". Does anyone know if editing a release has any implications other than how it is labeled?
from opentelemetry-proto.
Related Issues (20)
- Move examples out of spec into an examples folder HOT 1
- Enum element naming consistency HOT 1
- Schema support for span with key-value attributes HOT 2
- Question about ResourceSpans HOT 1
- Mention 1.0.0 in CHANGELOG.md? HOT 3
- Difference between proto and SDK HOT 2
- Why TraceID and SpanID are defined []byte type? HOT 4
- AnyValue diverging from spec on website HOT 2
- The comment of schema_url doesn't describe it's purpose.
- Clarify whether OTLP/gRPC codes should cover both client and server HOT 1
- Unclear whether Span.flags represents span's parent or own flags HOT 10
- Fix releasing notes HOT 3
- Allow consumers to use map<string, AnyValue> instead of repeated KeyValue HOT 3
- Generated OpenAPI files wrongly encode enums
- Improve metrics.proto by mentioning Resource Attributes and Scope HOT 1
- How to use Java service to receive data in the OpenTelemetry (Otel) protocol? HOT 4
- Supporting JSON as-is encoding in OTLP HOT 2
- SPAN_FLAGS_TRACE_FLAGS_MASK is not defined HOT 3
- Fail to push limit HOT 5
- Retryable HTTP Statuses should be configurable HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-proto.