Giter VIP home page Giter VIP logo

Comments (2)

tigrannajaryan avatar tigrannajaryan commented on September 26, 2024

I don't mind doing this change. Just a couple thoughts:

If one simply forgot to set this property to any value - it will mean 0 children which may be factually incorrect.

I guess what you are saying is that if a sender forgets to set any value then it is not possible for receiver to detect that it was not set and it should not be used. This is in contrast to other numeric fields where if one forgets to set the value the receiver has a good change to detect that something is wrong (e.g. if start_time_unixnano is 0 the receiver can easily detect it and treat it as bad data).

I agree with this line of thinking.

Depending on semantics of the field and how it should be used there may be no practical difference. Validation is only useful when this value > 0.

This makes sense to me. We will need to specify that value of 0 should not be used for validation purposes.

from opentelemetry-proto.

bogdandrutu avatar bogdandrutu commented on September 26, 2024

This filed was removed

from opentelemetry-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.