Comments (7)
The tests added as part of PR #1380 should be behind feature flag as well. @Rockin2 fyi.
from opentelemetry-rust.
Oops. I will fix that.
from opentelemetry-rust.
Can you assign me this issue?
from opentelemetry-rust.
We have another problem too. When I run cargo test in the opentelemetry-appender-tracing folder, it doesn't compile too because it needs the testing feature feature.
from opentelemetry-rust.
We have another problem too. When I run cargo test in the opentelemetry-appender-tracing folder, it doesn't compile too because it needs the testing feature feature.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-appender-tracing/src/layer.rs#L234 Yea all tests using inmemoryexporter needs testing feature.
from opentelemetry-rust.
The CI check is running fine...
running 4 tests
test layer::tests::tracing_appender_inside_tracing_context ... ok
test layer::tests::tracing_appender_inside_tracing_context_with_tracing_log ... ok
test layer::tests::tracing_appender_standalone ... ok
test layer::tests::tracing_appender_standalone_with_tracing_log ... ok
from opentelemetry-rust.
Instead of putting these tests inside a feature flag, I just added the dependencies in the dep.dependencies. The logic here is we don't have control on whether the user will use tracing_log or not. I could be activated in the application and the opentelemetry-appender-tracing crate doesn't need to depend on it to capture logs from the log crate with tracing.
from opentelemetry-rust.
Related Issues (20)
- Flaky test HOT 10
- [Bug]: incorrect docs on SdkMeterProvider.builder() HOT 2
- Flaky test in CI HOT 4
- [Bug]: PeriodicReader uses sync::Mutex.
- AttributeSet in the OpenTelemetry API HOT 4
- [Bug]: constructing a tonic builder defaults to connect to 4318? HOT 6
- Add Testing for Shutdown Scenarios. HOT 2
- ObservableCounter aggregation bug for cumulative
- [Feature]: remove the grpcio gRPC backend HOT 1
- Instrumentation scope - move to builder pattern? HOT 4
- [Feature]: Move `SpanLimits` to `opentelemetry` and use the limits in `SpanBuilder` HOT 3
- Prepare opentelemetry-prometheus for new protobuf version. HOT 5
- Use parameterization to simplify tests HOT 5
- Regulating our MSRV HOT 5
- Prometheus exporter dependency HOT 1
- Flaky test HOT 1
- [Bug]: missing attributes in prometheus exporter HOT 4
- Memory optimization for metric datapoints HOT 8
- OpenTelemetry Tracing API vs Tokio-Tracing API for Distributed Tracing HOT 3
- Overview of Major blockers for GA/Stable Release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-rust.