Giter VIP home page Giter VIP logo

Comments (7)

lalitb avatar lalitb commented on June 12, 2024

The tests added as part of PR #1380 should be behind feature flag as well. @Rockin2 fyi.

from opentelemetry-rust.

Rockin2 avatar Rockin2 commented on June 12, 2024

Oops. I will fix that.

from opentelemetry-rust.

Rockin2 avatar Rockin2 commented on June 12, 2024

Can you assign me this issue?

from opentelemetry-rust.

Rockin2 avatar Rockin2 commented on June 12, 2024

We have another problem too. When I run cargo test in the opentelemetry-appender-tracing folder, it doesn't compile too because it needs the testing feature feature.

from opentelemetry-rust.

cijothomas avatar cijothomas commented on June 12, 2024

We have another problem too. When I run cargo test in the opentelemetry-appender-tracing folder, it doesn't compile too because it needs the testing feature feature.

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-appender-tracing/src/layer.rs#L234 Yea all tests using inmemoryexporter needs testing feature.

from opentelemetry-rust.

cijothomas avatar cijothomas commented on June 12, 2024

https://github.com/open-telemetry/opentelemetry-rust/actions/runs/7185821321/job/19569877505#:~:text=running%204%20tests,tracing_appender_standalone_with_tracing_log%20...%20ok

The CI check is running fine...

running 4 tests
test layer::tests::tracing_appender_inside_tracing_context ... ok
test layer::tests::tracing_appender_inside_tracing_context_with_tracing_log ... ok
test layer::tests::tracing_appender_standalone ... ok
test layer::tests::tracing_appender_standalone_with_tracing_log ... ok

from opentelemetry-rust.

Rockin2 avatar Rockin2 commented on June 12, 2024

Instead of putting these tests inside a feature flag, I just added the dependencies in the dep.dependencies. The logic here is we don't have control on whether the user will use tracing_log or not. I could be activated in the application and the opentelemetry-appender-tracing crate doesn't need to depend on it to capture logs from the log crate with tracing.

from opentelemetry-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.