Giter VIP home page Giter VIP logo

Comments (3)

lalitb avatar lalitb commented on June 3, 2024 1

Ok, It was much simpler to add a special case to avoid LogData cloning in case of single processor ( I believe that would be the most common use-case). Have added that change as part of #1636 (as changes are closely tied to that PR). I can see vast improvement in stress test with that:

Main branch:

Number of threads: 8
Throughput: 16,356,200 iterations/sec
Throughput: 15,894,400 iterations/sec
Throughput: 16,018,200 iterations/sec
Throughput: 16,344,800 iterations/sec
PR branch: (with Resource propagation )

PR branch: (with Resource propagation at startup):

Number of threads: 8
Throughput: 19,301,400 iterations/sec
Throughput: 19,789,000 iterations/sec
Throughput: 20,133,600 iterations/sec
Throughput: 19,763,000 iterations/sec

PR branch: (with Resource propagation + avoid LogData clone for single processor)

Number of threads: 8
Throughput: 28,997,800 iterations/sec
Throughput: 29,057,800 iterations/sec
Throughput: 28,755,800 iterations/sec
Throughput: 29,712,000 iterations/sec

from opentelemetry-rust.

cijothomas avatar cijothomas commented on June 3, 2024

I meant to say - its best if we can do this, irrespective of the number of processors, not just optimize for the 1-processor scenario. Span current does the special case for single processor..But I think it should be possible to always pass ref or mut ref to processors.

from opentelemetry-rust.

lalitb avatar lalitb commented on June 3, 2024

updated title accordingly. The problem is, as of now there is no-single owner of the created LogRecord. So, to achieve passing ref/mut-ref, we need to first have an owner of this LogRecord, and then ensure that the record is not dropped while any of the references is being used. Need some investigation.

from opentelemetry-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.