Comments (3)
Ok, It was much simpler to add a special case to avoid LogData cloning in case of single processor ( I believe that would be the most common use-case). Have added that change as part of #1636 (as changes are closely tied to that PR). I can see vast improvement in stress test with that:
Main branch:
Number of threads: 8
Throughput: 16,356,200 iterations/sec
Throughput: 15,894,400 iterations/sec
Throughput: 16,018,200 iterations/sec
Throughput: 16,344,800 iterations/sec
PR branch: (with Resource propagation )
PR branch: (with Resource propagation at startup):
Number of threads: 8
Throughput: 19,301,400 iterations/sec
Throughput: 19,789,000 iterations/sec
Throughput: 20,133,600 iterations/sec
Throughput: 19,763,000 iterations/sec
PR branch: (with Resource propagation + avoid LogData clone for single processor)
Number of threads: 8
Throughput: 28,997,800 iterations/sec
Throughput: 29,057,800 iterations/sec
Throughput: 28,755,800 iterations/sec
Throughput: 29,712,000 iterations/sec
from opentelemetry-rust.
I meant to say - its best if we can do this, irrespective of the number of processors, not just optimize for the 1-processor scenario. Span current does the special case for single processor..But I think it should be possible to always pass ref or mut ref to processors.
from opentelemetry-rust.
updated title accordingly. The problem is, as of now there is no-single owner of the created LogRecord. So, to achieve passing ref/mut-ref, we need to first have an owner of this LogRecord, and then ensure that the record is not dropped while any of the references is being used. Need some investigation.
from opentelemetry-rust.
Related Issues (20)
- Broken trace example HOT 1
- Stabilize Gauge HOT 1
- Remove logs_level_enabled feature flag from Log API and SDK HOT 1
- [Metric API] Instrument validation error handling
- Alternate Proposal for OTel Tracing API vs Tokio-Tracing HOT 3
- [Metrics API] Do we need Unit abstraction?
- [Metrics API] - Add metrics to default features
- Signal feature flag name is not consistent HOT 1
- Public noops? HOT 1
- Metrics beta/rc/stable release timelines
- [Feature]: Support attribute Value variants for KeyValueList and bytes HOT 2
- opentelemetry-stdout to have all features HOT 1
- Logs beta/rc/stable release timelines
- Metrics SDK improvements
- [Metrics SDK] Shutdown false alarm HOT 1
- [Bug]: `opentelemetry_appender_tracing` does not work with blocking otlp exporter
- What should provider's force_flush return HOT 1
- OTLP Exporter must default to http/protobuf HOT 1
- Remove ordered_float dependency HOT 1
- OTLP Exporter with http/json is not working HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-rust.