Comments (8)
@avillela can you take a look at your blog post and figure out if the sentence can be rephrased to match what is discussed here. As a quick fix, I am also OK with removing the sentence entirely.
Thanks everyone. From the response so far it seems safe to say that various SDKs and instrumentations may automatically collect span exception events when setting the span status to ERROR, but we (specifically our vendor platform) should not make this assumption, correct?
That's my understanding as well, yes.
from opentelemetry.io.
Thanks for raising this @cheempz!
@reese-lee @avillela can you verify if this is somewhere defined in the spec and just not available in Python, or if this is not in the spec?
If it is in the spec, we can raise an issue with python or check if one exists already and close this issue
If it is not in the spec, let's remove that sentence from the blog post. Although we try to avoid changing blog posts after publication, I think it would be justified in this case to avoid future confusion.
from opentelemetry.io.
@open-telemetry/python-approvers if someone can take a look and help with answering this question, this would be great/can help to expedite the investigation
from opentelemetry.io.
I don't think we have that kind of magic in Python other than sdk's Span constructor will add to the span every event it get passed to it. Span.record_exception
will add the exception as event automatically, maybe they meant that?
from opentelemetry.io.
It's a convention in instrumentations to create a span event with a stack trace (or other error details), so that may be what was referred to? There's nothing inherent in OTel SDKs that create a span event automatically, though.
from opentelemetry.io.
Apologies - I think the wording we used might have been a bit confusing.
From my understanding in Python, if you have:
with tracer.start_as_current_span("do_roll", set_status_on_exception=True)
and your span throws an exception, then that span will be marked as an error span.
I believe that tracks with the above comments? If so, I'm happy to modify that sentence in the blog post to clarify the confusion.
from opentelemetry.io.
Thanks everyone. From the response so far it seems safe to say that various SDKs and instrumentations may automatically collect span exception
events when setting the span status to ERROR
, but we (specifically our vendor platform) should not make this assumption, correct?
from opentelemetry.io.
Closing as completed by #4844.
from opentelemetry.io.
Related Issues (20)
- [infra] Setup local cSpell word lists, and move `en` words out of .cspell.yml
- Wrong language for Accounting Service in architecture.md HOT 2
- OpenTelemetry Tracing Shim HOT 3
- Fix spell check to detect Spanish spelling errors HOT 4
- [i18n,infra] Adjust `normalize-cspell-front-matter.pl` to work with all localizations that have spell-checking enabled
- [infra] Consider displaying future pages like blog post and announcements, at least conditionally
- [CI] External link checking improvements for 24H2
- Wrong `PrometheusHttpServer` link in js exporters documentation HOT 3
- Documentation Request: Configuring OpenTelemetry with Spring Boot Micrometer HOT 5
- Link excerpts to source
- Building a custom collector HOT 4
- Blog post: Behind the scenes of the OpenTelemetry Governance Committee HOT 3
- Add a new persona: My Persona HOT 1
- On browser setting window.OTEL_SERVICE_NAME does not populate service.name HOT 5
- Feedback on context propagation conceptual docs HOT 4
- OpenSearch is not shown in the architecture doc HOT 1
- [ja] need to update the link for OpenTelemetry Contributor Guide in content/ja/docs/contributing/_index.md HOT 2
- Add a new persona: HaleyBoo HOT 1
- [ja] OTel L10N announcement blog post doesn't show up HOT 3
- Final release versions for OpenTelemetry.Instrumentation.AspNet and OpenTelemetry.Extensions.AWS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry.io.