Giter VIP home page Giter VIP logo

Comments (8)

svrnm avatar svrnm commented on August 28, 2024 1

@avillela can you take a look at your blog post and figure out if the sentence can be rephrased to match what is discussed here. As a quick fix, I am also OK with removing the sentence entirely.

Thanks everyone. From the response so far it seems safe to say that various SDKs and instrumentations may automatically collect span exception events when setting the span status to ERROR, but we (specifically our vendor platform) should not make this assumption, correct?

That's my understanding as well, yes.

from opentelemetry.io.

svrnm avatar svrnm commented on August 28, 2024

Thanks for raising this @cheempz!

@reese-lee @avillela can you verify if this is somewhere defined in the spec and just not available in Python, or if this is not in the spec?

If it is in the spec, we can raise an issue with python or check if one exists already and close this issue
If it is not in the spec, let's remove that sentence from the blog post. Although we try to avoid changing blog posts after publication, I think it would be justified in this case to avoid future confusion.

from opentelemetry.io.

svrnm avatar svrnm commented on August 28, 2024

@open-telemetry/python-approvers if someone can take a look and help with answering this question, this would be great/can help to expedite the investigation

from opentelemetry.io.

xrmx avatar xrmx commented on August 28, 2024

I don't think we have that kind of magic in Python other than sdk's Span constructor will add to the span every event it get passed to it. Span.record_exception will add the exception as event automatically, maybe they meant that?

from opentelemetry.io.

cartermp avatar cartermp commented on August 28, 2024

It's a convention in instrumentations to create a span event with a stack trace (or other error details), so that may be what was referred to? There's nothing inherent in OTel SDKs that create a span event automatically, though.

from opentelemetry.io.

avillela avatar avillela commented on August 28, 2024

Apologies - I think the wording we used might have been a bit confusing.

From my understanding in Python, if you have:

with tracer.start_as_current_span("do_roll", set_status_on_exception=True)

and your span throws an exception, then that span will be marked as an error span.

I believe that tracks with the above comments? If so, I'm happy to modify that sentence in the blog post to clarify the confusion.

from opentelemetry.io.

cheempz avatar cheempz commented on August 28, 2024

Thanks everyone. From the response so far it seems safe to say that various SDKs and instrumentations may automatically collect span exception events when setting the span status to ERROR, but we (specifically our vendor platform) should not make this assumption, correct?

from opentelemetry.io.

tiffany76 avatar tiffany76 commented on August 28, 2024

Closing as completed by #4844.

from opentelemetry.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.