Comments (5)
The append method was never fully implemented and was added to for a clone test case.
The original append method required a user to import a class, instantiate it and the append that instance which is counter to the intent of the library (no imports required by a user except for the single top level import).
Users of the original append method were advised that breaking changes were coming and to not use it.
The current refactored implementation is in use should not be commented out.
from openapiart.
The change to comment out the current append behavior should be reverted.
from openapiart.
sure Andy
@ashutshkumr, FYI
from openapiart.
I think both the behaviours are derived from valid use cases and we should decide whether to overload the meaning of append
or provide methods with different names.
First usecase
f1, f2 = config.flows.flow(name='f1').flow(name='f2')
# when most configurations in f2 and f3 are common
f3 = f2.clone()
f3.name = 'f3'
f1, f2, f3 = config.flows.append(f3)
Second usecase
f1, f2 = config.flows.flow(name='f1').flow(name='f2')
# when most configurations in f2 and f3 are not common
f3 = config.flows.append(name='f3')
from openapiart.
As discussed, for second use case above, we'll introduce add
.
f1, f2 = config.flows.flow(name='f1').flow(name='f2')
# when most configurations in f2 and f3 are not common
f3 = config.flows.add(name='f3')
from openapiart.
Related Issues (20)
- Required properties cannot be set with 'None'.
- schema which has required choices are throwing required validation error at time of initialization
- array properties using same schema does not work in go SDK
- Validation throws an error stating invalid type str when an out-of-range int (64 in this case) is passed in ("property port_number shall be of type <class 'int'> at <class 'port_model.Port'> \n got bad of type <class 'str'> , expected min 1, expected max 32"). Error message must not mention type if type is not an issue
- Any 2xx response should satisfy the response requirements for openapi requests
- Resolve references to #/components/parameters/<parameter name>
- Allow defining multiple response codes with empty content in the openapi spec
- Dev workflow is currently very painful
- Support Telemetry in sanppi
- Telemetry Support for go-snappi
- valid formats for supported integer type is not checked
- Fix validate(assertion) methods of snappi and gosnappi for integers
- x-field-pattern now should generate uint32 values instead of int values as packet headers generally does not have negative values
- Current unit test structure has weird nomenclature and is missing multiple edge cases, Need to have a new models schema for openapaiart unit test cases which is readable, well structured and covers all edge cases
- Fix controller CI dp python test cases and do changes in controller for the data type refactor. HOT 1
- Add ability to Connect to secured server using SSL/TLS in python SDK
- Generated .proto seems to convert upper case enum values to lower case enum values
- Un-marhsall for choice properties has issue
- Generate Unit Tests for SDKs
- Schema validation errors are not helpful to pinpoint exact line which has the bad keyword/typo.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapiart.