Giter VIP home page Giter VIP logo

Comments (4)

thepassle avatar thepassle commented on June 12, 2024

Some things to think about are:

  • Do we want to add the CEM to the users .gitignore, and then make sure the analyzer runs on prepublish?

I know some people have strong opinions on code reviews/making sure that the CEM has updated correctly, I also know people wont like seeing CEM changes in their PRs necessarily, so we'd have to make some kind of decision there.

  • When do we run CEM?

Clever cloud starts the analyzer in watch mode kind of as a side effect of the web dev server config, so the analyzer will always run when the server runs. We could also consider creating a separate dev-server plugin to run the analyzer, maybe thats a bit 'cleaner'.

It would be nice to have the analyzer run in watch mode especially when the new version of storybook releases and makes its way into storybook-prebuilt, because then users will have up-to-date knobs/controls as they write code.

from create.

bennypowers avatar bennypowers commented on June 12, 2024

i think we shouldn't check the manifest in. imo it's a build artifact
for the dev server plugin, I think we should develop that separately, then add it here as a feat.

should that plugin live in cem repo or dev server repo cc @LarsDenBakker
we have infra to add a plugin to cem repo, seems natural to me to put it there

from create.

thepassle avatar thepassle commented on June 12, 2024

i think we shouldn't check the manifest in. imo it's a build artifact

I agree. Maybe we go with that for now, we can always change it

should that plugin live in cem repo or dev server repo cc @LarsDenBakker

I think its fine to add it to the cem repo

from create.

bennypowers avatar bennypowers commented on June 12, 2024

ok i'll start here then swing back to the build plugin if i have time

from create.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.