Comments (4)
Some things to think about are:
- Do we want to add the CEM to the users
.gitignore
, and then make sure the analyzer runs on prepublish?
I know some people have strong opinions on code reviews/making sure that the CEM has updated correctly, I also know people wont like seeing CEM changes in their PRs necessarily, so we'd have to make some kind of decision there.
- When do we run CEM?
Clever cloud starts the analyzer in watch mode kind of as a side effect of the web dev server config, so the analyzer will always run when the server runs. We could also consider creating a separate dev-server plugin to run the analyzer, maybe thats a bit 'cleaner'.
It would be nice to have the analyzer run in watch mode especially when the new version of storybook releases and makes its way into storybook-prebuilt, because then users will have up-to-date knobs/controls as they write code.
from create.
i think we shouldn't check the manifest in. imo it's a build artifact
for the dev server plugin, I think we should develop that separately, then add it here as a feat.
should that plugin live in cem repo or dev server repo cc @LarsDenBakker
we have infra to add a plugin to cem repo, seems natural to me to put it there
from create.
i think we shouldn't check the manifest in. imo it's a build artifact
I agree. Maybe we go with that for now, we can always change it
should that plugin live in cem repo or dev server repo cc @LarsDenBakker
I think its fine to add it to the cem repo
from create.
ok i'll start here then swing back to the build plugin if i have time
from create.
Related Issues (20)
- Consider adding a favicon.ico file.
- Does not offer option to build with rollup HOT 1
- Link in the initial create process leads to a 404 HOT 1
- [test]: e2e tests
- README should be user-facing HOT 1
- rollup.config.js output is different from manual setup docs
- Improve feedback when custom element name is not to spec
- consider using validate-element-name package
- Dependency Dashboard
- Upgrading an existing project throws HOT 4
- Adding storybook misses command HOT 1
- Possible to remove tsc and use plugins instead? HOT 1
- Error while transforming node_modules/@web/storybook-prebuilt/manager.js: Could not resolve import "react".
- Upgrading and multi-components
- Old litElement HMR preset is referenced by template HOT 3
- Hiva
- Error on newly-created project HOT 5
- Storybook Does Not Work Out of the Box
- [app] Storybook Does Not Work Out of the Box
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create.