Giter VIP home page Giter VIP logo

Comments (4)

kamilbaranek avatar kamilbaranek commented on May 9, 2024

Yes please, upvoting for that! Better error handling would be much appreciated!

from client.

ali-m2020 avatar ali-m2020 commented on May 9, 2024

Just to be clear, I have already done the needed changes in the codes on my local machine and the above test passes nicely.
I have achieved this with minimum changes necessary, though one may suggest bigger and more fundamental changes to the structure of the whole component, I found it not needed at presence.
Plus, I stopped using this component in favor of using the native Symfony Httpclient instead of this nice component, due to its entangled use of Guzzle.

from client.

gehrisandro avatar gehrisandro commented on May 9, 2024

Hi @ali-m2020

Thank you for input. But I can't see what the benefit of not throwing an exception should be, because in my opinion all the 4 things you mentioned should be possible with the current implementation.

Furthermore, not throwing an exception and returning a valid response object with a new "error" attribute would require an additional check after every request to ensure the returned response has no error.
With the current implementation this check is not required as the developer can be sure, that every response received is valid and no error has occurred.

If I misunderstand your request or there is a concrete error which you are not able to handle properly, please let us know.

@kamilbaranek Why did you upvote for this feature? What change would you expect?

from client.

gehrisandro avatar gehrisandro commented on May 9, 2024

closed due to inactivity

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.