Excessive limitation checks and logging when Custom Peak time below limit of active insulin curve about oref0 HOT 8 OPEN

If you’re seeing this in FreeAPS-X, you should probably open an issue there, and once the problem is identified and fixed, see if any changes need to be upstreamed here to oref0.

Alternatively you could try to reproduce the problem in oref0 itself, but based on your hardware I think you’d have compatibility issues trying that.

from oref0.

FreeAPS-X just uses the standard OpenAPS, I think the problem should arise on pi-Rig as well. Yes I cannot test, can you? Reproduction should be easy

curve: "rapid-acting" ,
useCustomPeakTime: true,
insulinPeakTime: 48,

from oref0.

This issue is partially reproducible on my Pi rig. I see the log spam in /var/log/openaps/shared-node.log but you wouldn't know it from looking at /var/log/openaps/pump-loop.log. It doesn't cause any loop failures on the Pi. I am working on a fix.

from oref0.

This issue can be closed; it would have been closed automatically but the PR was "closed" instead of "merged" despite the changes being committed to dev.

from oref0.

Per #1437 (comment) I had to revert this fix via 10f9e27

The new code was causing future IOB predictions to be incorrect (highly negative).
That causes the predBG lines to swoop up and to the right.
That results in (slightly) too much insulin being dosed in some situations.

from oref0.

@ChanceHarrison or @scottleibrand is there another solution on the horizon?

from oref0.

I am not working on the issue. Would you like to?

from oref0.

No unfortunatly those interaction with the other files are above my laymans skill level.

from oref0.