Giter VIP home page Giter VIP logo

Comments (9)

tladesignz avatar tladesignz commented on June 30, 2024

What you can achieve with Orbot / OrbotKit is to check, if the Orbot "VPN" is running, and if not, tell the user and deny start of app or start of upload, until they start Orbot or override.

However, to start the VPN, we need to do this via a UX jump into the Orbot app. Since the VPN is not running, there's no REST API we could talk to in the background to achieve this.

from save-app-ios.

johnhess avatar johnhess commented on June 30, 2024

What you can achieve with Orbot / OrbotKit is to check, if the Orbot "VPN" is running, and if not, tell the user and deny start of app or start of upload, until they start Orbot or override.

Having an assurance you're not uploading without the VPN is great! Let's go that route, even if it means bouncing users over to another app to start it.

from save-app-ios.

tladesignz avatar tladesignz commented on June 30, 2024

Will be contained in next TestFlight (build 64) coming later today!

from save-app-ios.

tladesignz avatar tladesignz commented on June 30, 2024

Oh, just recognized: With the first implementation, I don't bounce the user anywhere.

It just silently stops uploading more items.

What's the right time to tell the user that they requested to only upload via Orbot, but Orbot is not running?

Another thing I need to fix:

  • A running upload is currently not stopped immediately. There's just no further uploads. Will need to cancel running uploads, too!

from save-app-ios.

johnhess avatar johnhess commented on June 30, 2024

I'd prefer to be conservative so we don't unwittingly route uploads over the ordinary network. I'm thinking that probably means whenever we make a call to upload, whether that's immediately upon clicking "upload" or whether the user re-opens the app and uploads resume.

Are there other edge cases we should be thinking about? For example, if a user enables the VPN, clicks "upload" for 5 files and then quits the app and re-opens the app later after they've turned off the VPN? In short, I understand there's a way to make sure we don't request the OS upload the file while the VPN is off. Is there a way to ensure the async call actually runs over the VPN?

from save-app-ios.

tladesignz avatar tladesignz commented on June 30, 2024

Another TestFlight incoming adressing the last pieces! (build 65).

Alert texts are completely my own. A non-native speaker. Please review and improve!

from save-app-ios.

purvi-ranawat avatar purvi-ranawat commented on June 30, 2024

The issue still exists. Nothing related to the Orbot is mentioned on the onboarding slides. In Android, we get the option to install Orbot during onboarding. But on IOS, we do not get Install Orbot on the onboarding slides and user might not know anything related to Orbot.

Attached is the video link :

https://drive.google.com/file/d/1dWDDtENrReKWSMQyOJBiyXjbDqFnCIFG/view?usp=sharing

from save-app-ios.

tladesignz avatar tladesignz commented on June 30, 2024

Good thinking! I added the slide. It works slightly differently, because Orbot iOS works slightly differently, but now we drag the user right into Orbot usage. :-)

Will be contained in next Testflight (build 66)

from save-app-ios.

purvi-ranawat avatar purvi-ranawat commented on June 30, 2024

@tladesignz / @johnhess : This is working fine. Now I am able to see Orbot installation and enabling during the onboarding slides.

This is working in build 66

from save-app-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.