Sensor override broken after 3e35c761b7 (and maybe before that too) about bmcweb HOT 5 CLOSED

ACK, yeah, that looks like a really unfortunate side effect that I certainly didn't expect when merging that code. In terms of priority, I think we did get that right. A failing service validator effects EVERY platform, so if the two requirements are mutually exclusive, I'd much rather have a passing service validator than have sensor override (which I don't think is actually enabled on anything but downstream platforms).

With that said, lets see if we can get it working for both. I think to fix that, it's going to require us to go back to building the entire sensor tree, to determine the index of the sensor in question, then firing it to that path. Let me know if you need help rearranging the code.

from bmcweb.

@carsonlab suggested we try to modify 3e35c76. As the only requirement is that MemberId needs to match the end of URI, could we just make the end of URI be the sensor name and preserve the old MemberId format? That way we wouldn't need to rebuild the sensor tree to map MemberId into a Name.

from bmcweb.

That's probably reasonable. Please make sure the validator passes on whatever change we make.

from bmcweb.

As a short term fix, reverting 3e35c76 and c71d612 works.

curl localhost/redfish/v1/Chassis/Tray/Thermal#/Fans
...
    {
      "@odata.id": "/redfish/v1/Chassis/Tray/Thermal#/Fans/0",
      "@odata.type": "#Thermal.v1_3_0.Fan",
      "MaxReadingRange": 100,
      "MemberId": "fan0_pwm",
      "MinReadingRange": 0,
      "Name": "fan0 pwm",
      "Reading": 29,
      "ReadingUnits": "Percent",
      "Status": {
        "Health": "OK",
        "State": "Enabled"
      }
    },
...

curl --data '{"Fans":[{"MemberId": "fan0_pwm", "Reading": 50}]}' -X PATCH localhost/redfish/v1/Chassis/Tray/Thermal#/Fans/
{
  "@odata.id": "/redfish/v1/Chassis/Tray/Thermal",
  "@odata.type": "#Thermal.v1_4_0.Thermal",
  "Fans": [],
  "Id": "Thermal",
  "Name": "Thermal",
  "Temperatures": []
}

curl localhost/redfish/v1/Chassis/Tray/Thermal#/Fans
...
    {
      "@odata.id": "/redfish/v1/Chassis/Tray/Thermal#/Fans/0",
      "@odata.type": "#Thermal.v1_3_0.Fan",
      "MaxReadingRange": 100,
      "MemberId": "fan0_pwm",
      "MinReadingRange": 0,
      "Name": "fan0 pwm",
      "Reading": 50,
      "ReadingUnits": "Percent",
      "Status": {
        "Health": "OK",
        "State": "Enabled"
      }
    },
...

Based on the second commit, shouldn't have it "fixed" sensor overrides? But instead its causing the dbus error I mentioned previously.

from bmcweb.

This was resolved with https://gerrit.openbmc.org/c/openbmc/bmcweb/+/64528

from bmcweb.