Giter VIP home page Giter VIP logo

Comments (3)

mpbraendli avatar mpbraendli commented on June 24, 2024

Yep. I didn't want to support too many options, to reduce amount of testing and documentation.
If you have a need you cannot reasonably cover with the existing options, please open the ticket again and explain why it would make sense to include IPC.
Thanks!

from odr-audioenc.

MaPePeR avatar MaPePeR commented on June 24, 2024

I think it would not need any additional testing or documentation, because that is entirely handled by zmq. Just need to make the zmq endpoint argument accept all the valid zmq endpoints instead of filtering for specific protocols.

The dabmux even accepts IPC, I think, but audioenc cannot output it, because the protocol is not recognized as zmq.

But you are right: one can just use TCP, but I think IPC has the benefit of not using the TCP stack and being more optimized.

And it just requires an additional accepted prefix for zmq in the argument parsing logic, or removing that logic all together and not trying to pre validate the zmq endpoints, because that should be handled by the library itself.

from odr-audioenc.

mpbraendli avatar mpbraendli commented on June 24, 2024

It's not the "what does it do" nor "how does the protocol work" that needs documentation, it's "when to use it". That's what the guide and the scenarios in the README aim to present.

And the only things that don't need additional testing are things you do not support. That was also my reasoning behind putting the validation in the code.

But that doesn't mean it has to stay like that. The advantage I see with the ipc transport is that you don't block TCP ports (I cannot say anything about one being more optimized than the other).

I'm fine with elevating ipc to the same level of support as epgm, which is to say "use at your own risk, we don't guarantee anything", and I'd welcome a patch adding ipc:// to the list or removing the check (but filename detection needs to be done differently) and update the usage screen accordingly.

from odr-audioenc.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.