Comments (4)
@chahmedejaz that sounds good! Many thanks. I assume you did it, but in doubt: we need this message to have a translation key.
I'm curious: do you have an example of cloning fail we could use when testing this PR?
from openfoodnetwork.
@RachL, @drummer83 -
I assume you did it, but in doubt: we need this message to have a translation key
Yes, Rachel, it will have :)
I'm curious: do you have an example of cloning fail we could use when testing this PR?
Could you please add instructions on how to make cloning fail during testing on our staging server?
This happens only for very old products that don't have valid data as per our current product/variant validations. Normally it would be very hard to reproduce unless we have very old products that were created at the time we didn't have new validations.
I have DB access, so I could also tweak or delete some entries on that variant manually, if required.
Sure Konrad, one of the ways you can create invalid products is to set nil
to product's variant_unit
. When you clone this product, then it will fail. However, doing this will cause some unexpected UI behavior which can be ignored for the sake of its testing.
You may refer to this spec which validates this failure case:
openfoodnetwork/spec/system/admin/products_v3/actions_spec.rb
Lines 266 to 278 in 50ebfe4
Please let me know if you have any questions. Thanks
from openfoodnetwork.
Hi @drummer83 - I've implemented it in such a way that the errors that can be fixed by the user will display which field has an invalid value. Any other errors will still display the default one.
Please review the new error message. Thanks.
CC: @RachL
from openfoodnetwork.
Thank you, @chahmedejaz! That's fine by me. The text can always be adjusted in Transifex.
Could you please add instructions on how to make cloning fail during testing on our staging server?
I have DB access, so I could also tweak or delete some entries on that variant manually, if required.
from openfoodnetwork.
Related Issues (20)
- [Flaky] spec/system/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb HOT 2
- [BUU, FR locale] Error 500 when accessing the products page
- v4.5.4 Orange roll HOT 2
- NoMethodError in Admin::ProductsV3#index - Only when using the hu.yml locale HOT 5
- [Admin] UX improvements for creation of new products HOT 1
- Reports not loading after multiple clicks/not loading on screen HOT 4
- Some products not showing on Hungarian instance shopfront HOT 2
- [BUU] Activate admin_style_v3 for 75% of users
- 500 error due to database connection pool being empty
- Release v4.6 HOT 3
- Bugsnag is being rate limited HOT 1
- Bulk Coop supplier report broken
- Products not loading on shopfront: S3 exception HOT 1
- As an admin, I can preview how products will appear in the store
- [Subscriptions] Error 500 when clicking link to order of a failed subscription due to stock zero
- [Product Categories] Clearer error message and clean up
- [Admin] [Order cycles] Cancel button of popup should redirect to OC list
- [Admin] [Order Cycles] Add warning popup to order cycle list as well
- Display Unit As field is not displaying on invoice HOT 2
- Fix Artifact Upload Conflicts with Unique Node-Based Names
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openfoodnetwork.