[BUU] No explanation why cloning failed about openfoodnetwork HOT 4 OPEN

@chahmedejaz that sounds good! Many thanks. I assume you did it, but in doubt: we need this message to have a translation key.

I'm curious: do you have an example of cloning fail we could use when testing this PR?

from openfoodnetwork.

@RachL, @drummer83 -

I assume you did it, but in doubt: we need this message to have a translation key

Yes, Rachel, it will have :)

I'm curious: do you have an example of cloning fail we could use when testing this PR?

Could you please add instructions on how to make cloning fail during testing on our staging server?

This happens only for very old products that don't have valid data as per our current product/variant validations. Normally it would be very hard to reproduce unless we have very old products that were created at the time we didn't have new validations.

I have DB access, so I could also tweak or delete some entries on that variant manually, if required.

Sure Konrad, one of the ways you can create invalid products is to set nil to product's variant_unit. When you clone this product, then it will fail. However, doing this will cause some unexpected UI behavior which can be ignored for the sake of its testing.
You may refer to this spec which validates this failure case:

from openfoodnetwork.

Hi @drummer83 - I've implemented it in such a way that the errors that can be fixed by the user will display which field has an invalid value. Any other errors will still display the default one.
Please review the new error message. Thanks.

CC: @RachL

from openfoodnetwork.

Thank you, @chahmedejaz! That's fine by me. The text can always be adjusted in Transifex.

Could you please add instructions on how to make cloning fail during testing on our staging server?
I have DB access, so I could also tweak or delete some entries on that variant manually, if required.

from openfoodnetwork.