Comments (5)
Ah, if there's no AlchemicalSystem
, then ChemicalSystem
is fine -- I just meant that if both exist then they should be as similar as possible.
Thinking more, I do slightly lean toward something with Chemical
in the name to avoid possible namespace confusion, since ComponentCollection
could just as easily come from a non-chemical library (quick GitHub search shows about 150k times people have used ComponentCollection
in code, though vast majority are due to CakePHP. Compare with ~1k for ChemicalSystem
and a whopping 51 for ChemicalComponents
.)
from gufe.
My vote would be ChemicalSystem, I generally like the idea of being able to say that what happens in the edges are AlchemicalSystems
from gufe.
I'm in favor of getting away from anything with State
, as that tends to be a term that is quickly overloaded.
ChemicalSystem
and AlchemicalSystem
would imply to me that the two implement similar APIs (as much duck-typing as possible). Is this the plan? If so, I'm in favor of this. Otherwise, I lean a little toward ChemicalComponents
but think that ComponentCollection
is about equally as good.
from gufe.
ChemicalSystem
andAlchemicalSystem
would imply to me that the two implement similar APIs (as much duck-typing as possible). Is this the plan?
yeah you're right I guess they won't be the same (indeed AlchemicalSystem
probably won't even exist)
from gufe.
I'm for ChemicalSystem
since it gives a sense of the object's intention vs. what it mechanically does (e.g. ComponentCollection
).
from gufe.
Related Issues (20)
- Add tests for PR #265
- [CI] CONDA CRON FAILURE macos-12 python 3.11
- [CI] CONDA CRON FAILURE macos-12 python 3.9
- [CI] CONDA CRON FAILURE macos-12 python 3.10
- Add compression approach to Numpy arrays when passed through JSON encoder
- RDKit `Mol` doesn't preserve atom properties when pickled; impacts `ExplicitMoleculeComponent` and subclasses HOT 2
- Define `AlchemicalArchive` object for use as archival artifact
- [CI] CONDA CRON FAILURE ubuntu-latest python 3.10
- Improve gufe partial charge checks
- Allow for storing & retreiving PDBResidueInfo for SMCs
- user-set partial charge warning HOT 1
- Add concept of `samples` to `Protocol.create`? HOT 2
- Implement settings thermodynamic equality HOT 1
- Fix settings for upcoming changes to openff-models for pydantic >=2
- [CI] CONDA CRON FAILURE ubuntu-latest python 3.10
- mapping affected by charge assignation
- Remove README note of this being "pre-alpha" work, since 1.0 release makes certain guarantees
- [CI] CONDA CRON FAILURE ubuntu-latest python 3.11
- [CI] CONDA CRON FAILURE ubuntu-latest python 3.9
- [CI] CONDA CRON FAILURE ubuntu-latest python 3.10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gufe.