`ChemicalState` naming about gufe HOT 5 CLOSED

Ah, if there's no AlchemicalSystem, then ChemicalSystem is fine -- I just meant that if both exist then they should be as similar as possible.

Thinking more, I do slightly lean toward something with Chemical in the name to avoid possible namespace confusion, since ComponentCollection could just as easily come from a non-chemical library (quick GitHub search shows about 150k times people have used ComponentCollection in code, though vast majority are due to CakePHP. Compare with ~1k for ChemicalSystem and a whopping 51 for ChemicalComponents.)

from gufe.

My vote would be ChemicalSystem, I generally like the idea of being able to say that what happens in the edges are AlchemicalSystems

from gufe.

I'm in favor of getting away from anything with State, as that tends to be a term that is quickly overloaded.

ChemicalSystem and AlchemicalSystem would imply to me that the two implement similar APIs (as much duck-typing as possible). Is this the plan? If so, I'm in favor of this. Otherwise, I lean a little toward ChemicalComponents but think that ComponentCollection is about equally as good.

from gufe.

ChemicalSystem and AlchemicalSystem would imply to me that the two implement similar APIs (as much duck-typing as possible). Is this the plan?

yeah you're right I guess they won't be the same (indeed AlchemicalSystem probably won't even exist)

from gufe.

I'm for ChemicalSystem since it gives a sense of the object's intention vs. what it mechanically does (e.g. ComponentCollection).

from gufe.