Giter VIP home page Giter VIP logo

Comments (8)

Leonils avatar Leonils commented on June 13, 2024

image

Proposal for the database modeling

from jitsi-magnify.

Leonils avatar Leonils commented on June 13, 2024

@sampaccoud. Would it be possible to review this database model ?

from jitsi-magnify.

sampaccoud avatar sampaccoud commented on June 13, 2024

The graph would be easier to read if you liste the foreign keys and many to many links? Not sure if it's possible.

For Meeting:
Use DateTimeField instead of DateField. You don't need the boolean fields for days of the week as you can do start.day... In our https://github.com/openfun/marsha project from which you can reuse a lot of code as it is based on Grommet and the same Ux design as yours... we have chosen to define start and estimated_duration instead of end... and we derive the end by calculating start + estimated_duration. See in this app for example : https://github.com/openfun/marsha/blob/master/src/backend/marsha/bbb/models.py#L108

I didn't understand in groups the sentence : "for anonymous users we create a link". But indeed we need a way to define some emails (phone numbers?) as members of a group for users that don't have an account, right?

For roles on a group or a room, I think we need through models to carry the role? Maybe they can be drawn on the graph.

For Jitsi settings, will it be a json document that we save? Can we retrieve it for an on-going conf from the API? Or should we manually detail in a form all the settings that we want to allow saving?

from jitsi-magnify.

Leonils avatar Leonils commented on June 13, 2024

Graph
Yes, we can work on that

Meetings
A meeting has indeed a start (startTime, or better start_time) and a duration (duration, or estimated_duration). But it can be recursive: "any Monday, Thursday, Friday, at 10AM, from the June 6th to the July 8th. So the boolean allow to encode it in an easy way (and easy to retrieve too)

Reuse of marsha
If we need to reuse parts of the code of marsha, the best would be to extract it from marsha to a third lib... not an easy task to achieve... That's the kind of consideration that make me a fan of making small reusable libraries.

Groups
In the groups, we imagine 2 ways of adding user to a group:

  • Either we invite users by adding their email, and so they need to connect using an account proving they possess this email (either on magnify, or on another provider)
  • Or we generate a link for this group, with a token and a tokenId, and any user accessing the meeting with this token is considered as a member of this group.

Roles
This should be discussed indeed. For now we assumed a room can have a single admin (by default the creator of the room), and many groups that are members. A meeting can also have a single admin (by default the admin of the room) a groups that are invited. Do we need a mode elaborate role system ?

Settings
For now, I'm not sure of the structure of the settings. If it's a simple key-value, we can keep it in the pg database. It would be better if we can save it from a meeting indeed.

from jitsi-magnify.

Leonils avatar Leonils commented on June 13, 2024

Here is an update on the database model, with improved naming and relation displayed.

image

from jitsi-magnify.

sampaccoud avatar sampaccoud commented on June 13, 2024

Jitsi settings : in Django the name settings is already used for something else... so maybe call it JitsiConfiguration.
Since you already have a group Membership class, I would add a field "role" to it and avoid the "admin" foreignkey to duplicate the membership...
For the room admin : ok to start with only one admin in the Ux but it's not much more expensive to materialize the foreignkey via a relation as well in db knowing that you want several admin users soon? The hard part that will delay the feature is the frontend I think.

from jitsi-magnify.

sampaccoud avatar sampaccoud commented on June 13, 2024

Note that AbstractUser does not really exist in db. It is only Python code inheritance but there is only 1 User db table.

from jitsi-magnify.

DarkPitoune avatar DarkPitoune commented on June 13, 2024

Updated version

image

from jitsi-magnify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.