Giter VIP home page Giter VIP logo

Comments (2)

Calvin1602 avatar Calvin1602 commented on June 12, 2024

Hi Baslack, thanks for your feedback.

The formulas you're suggestion are indeed the full Gram-Schmidt formulas, and should be correct. However, I don't think the current implementation is broken (although I admit there's a tricky shortcut) :

  • By construction, t is orthogonal to n (line 37)
  • By construction, b is orthogonal to n (line 38)
  • The only missing part is that t should be orthogonal to b, too.
  • Line 61 does just that.

Do you have a case where this breaks ?
Sincerely,
Arnaud

from ogl.

baslack avatar baslack commented on June 12, 2024

Nope, I don't. I just couldn't figure out what you were doing, which kinda of defeats the purpose of a tutorial.

And I still don't quite follow how line 61 makes t orthogonal to b. Looking at one of the references you mentioned: Lengyel’s Method. That line seems to match the first part of the projection process, but the second is missing, hence my addition. Could you explain in a bit more detail for me?

-B

from ogl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.