Giter VIP home page Giter VIP logo

Comments (14)

morph166955 avatar morph166955 commented on September 26, 2024

It looks like it could be tied to com.amazonaws.aws-java-sdk-core_1.12.626 which may be from pollytts.

from openhab-addons.

J-N-K avatar J-N-K commented on September 26, 2024

Yes, looks like that. Do you have any experience with pollytts? Maybe we can upgrade that dependency.

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

Only as an end user to generate audio notifications.

from openhab-addons.

J-N-K avatar J-N-K commented on September 26, 2024

I guess that is enough. According to https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-core/1.12.626 our version of aws-java-sdk-core already depends on 4.5.13, so it should be easy to update.

from openhab-addons.

J-N-K avatar J-N-K commented on September 26, 2024

IHC and IPP also depend on httpclient-osgi and httpcore-osgi, maybe qe can use the same version for all of them.

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

When I go and look at the bundle dependencies in karaf I get...

com.amazonaws.aws-java-sdk-core_1.12.626 [266] requires:
--------------------------------------------------------
osgi.wiring.package; (osgi.wiring.package=org.apache.http) resolved by:
   osgi.wiring.package; org.apache.http 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.auth) resolved by:
   osgi.wiring.package; org.apache.http.auth 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.client) resolved by:
   osgi.wiring.package; org.apache.http.client 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.client.config) resolved by:
   osgi.wiring.package; org.apache.http.client.config 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.client.methods) resolved by:
   osgi.wiring.package; org.apache.http.client.methods 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.client.protocol) resolved by:
   osgi.wiring.package; org.apache.http.client.protocol 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.config) resolved by:
   osgi.wiring.package; org.apache.http.config 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.conn) resolved by:
   osgi.wiring.package; org.apache.http.conn 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.conn.routing) resolved by:
   osgi.wiring.package; org.apache.http.conn.routing 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.conn.socket) resolved by:
   osgi.wiring.package; org.apache.http.conn.socket 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.conn.ssl) resolved by:
   osgi.wiring.package; org.apache.http.conn.ssl 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.entity) resolved by:
   osgi.wiring.package; org.apache.http.entity 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.impl.auth) resolved by:
   osgi.wiring.package; org.apache.http.impl.auth 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.impl.client) resolved by:
   osgi.wiring.package; org.apache.http.impl.client 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.impl.conn) resolved by:
   osgi.wiring.package; org.apache.http.impl.conn 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.impl.execchain) resolved by:
   osgi.wiring.package; org.apache.http.impl.execchain 4.5.5 from org.apache.httpcomponents.httpclient_4.5.5 [270]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.impl.io) resolved by:
   osgi.wiring.package; org.apache.http.impl.io 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.params) resolved by:
   osgi.wiring.package; org.apache.http.params 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.pool) resolved by:
   osgi.wiring.package; org.apache.http.pool 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]
osgi.wiring.package; (osgi.wiring.package=org.apache.http.protocol) resolved by:
   osgi.wiring.package; org.apache.http.protocol 4.4.9 from org.apache.httpcomponents.httpcore_4.4.9 [271]

When I look at PollyTTS pom.xml I only see...

    <dependency>
      <groupId>org.openhab.osgiify</groupId>
      <artifactId>com.amazonaws.aws-java-sdk-core</artifactId>
      <version>1.12.626</version>
      <scope>compile</scope>
    </dependency>

So I'm confused how maven/karaf is pulling an older version of the http client if 1.12.626 requires the newer version.

from openhab-addons.

J-N-K avatar J-N-K commented on September 26, 2024

Because the older version is defined in the feature.xml.

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

Ah, thank you. I did not see that. I can submit a PR on the openhab-addons side to update those lines.

Can you pull this issue up to that repo since this looks more addon specific than core?

from openhab-addons.

J-N-K avatar J-N-K commented on September 26, 2024

Can you also check IHC and IPP?

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

This is current...

IPP:

    <dependency>
      <groupId>org.apache.httpcomponents</groupId>
      <artifactId>httpcore-osgi</artifactId>
      <version>4.4.15</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.httpcomponents</groupId>
      <artifactId>httpclient-osgi</artifactId>
      <version>4.5.13</version>
      <scope>compile</scope>
    </dependency>

IHC:

    <dependency>
      <groupId>org.apache.httpcomponents</groupId>
      <artifactId>httpcore-osgi</artifactId>
      <version>4.4.10</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.httpcomponents</groupId>
      <artifactId>httpclient-osgi</artifactId>
      <version>4.5.8</version>
      <scope>compile</scope>
    </dependency>

I'm pushing pollytts to:

                <bundle dependency="true">mvn:org.apache.httpcomponents/httpcore-osgi/4.4.13</bundle>
                <bundle dependency="true">mvn:org.apache.httpcomponents/httpclient-osgi/4.5.13</bundle>

I can align IHC and IPP to those although it looks like IPP core would be a downgrade.

To note, using https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient/4.5.13 showing core as 4.4.13 for that alignment/decision.

from openhab-addons.

lolodomo avatar lolodomo commented on September 26, 2024

Is pollytts currently broken in main branch ?

from openhab-addons.

jlaur avatar jlaur commented on September 26, 2024

Is pollytts currently broken in main branch ?

@morph166955, did you see this question? We need to consider whether #16294 is needed for 4.2M1.

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

I've not had a chance to check. I've been incredibly busy this month with some personal things.

from openhab-addons.

morph166955 avatar morph166955 commented on September 26, 2024

This is still an issue on the current snapshot:

2024-03-02 13:56:14.154 [INFO ] [org.openhab.core.Activator          ] - Starting openHAB 4.2.0 (Build #3964)
...
2024-03-02 13:56:35.132 [WARN ] [zonaws.http.apache.utils.ApacheUtils] - NoSuchMethodException was thrown when disabling normalizeUri. This indicates you are using an old version (< 4.5.8) of Apache http client. It is recommended to use http client version >= 4.5.9 to avoid the breaking change introduced in apache client 4.5.7 and the latency in exception handling. See https://github.com/aws/aws-sdk-java/issues/1919 for more information

271 │ Active │  80 │ 4.5.5                  │ org.apache.httpcomponents.httpclient
272 │ Active │  80 │ 4.4.9                  │ org.apache.httpcomponents.httpcore

from openhab-addons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.