Giter VIP home page Giter VIP logo

Comments (3)

J-N-K avatar J-N-K commented on September 26, 2024

@wborn could this be related to #16235?

from openhab-addons.

wborn avatar wborn commented on September 26, 2024

Yes it could be that one of the futures never completes and it then keeps waiting forever:

openhab-addons/bundles/org.openhab.binding.network/src/main/java/org/openhab/binding/network/internal/PresenceDetection.java

Lines 378 to 380 in 9e1f87d

logger.debug("Waiting for {} detection futures for {} to complete", completableFutures.size(), hostname);
completableFutures.forEach(CompletableFuture::join);
logger.debug("All {} detection futures for {} have completed", completableFutures.size(), hostname);

Perhaps a max timeout can be used or it should interrupt the future when the next presence detection starts when it takes too long or it failed to complete.

Perhaps it should also not use the common scheduledExecutorService as it may take a while before all futures complete:

openhab-addons/bundles/org.openhab.binding.network/src/main/java/org/openhab/binding/network/internal/PresenceDetection.java

Line 395 in 9e1f87d

}, scheduledExecutorService);

from openhab-addons.

wborn avatar wborn commented on September 26, 2024

Maybe you can give #16315 a try @J-N-K?

from openhab-addons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.